policycoreutils: run_init: define _GNU_SOURCE#493
Closed
tpetazzoni wants to merge 1 commit intoSELinuxProject:mainfrom
Closed
policycoreutils: run_init: define _GNU_SOURCE#493tpetazzoni wants to merge 1 commit intoSELinuxProject:mainfrom
tpetazzoni wants to merge 1 commit intoSELinuxProject:mainfrom
Conversation
Trying to compile run_init with musl will fail with:
run_init.c: In function 'authenticate_via_shadow_passwd':
run_init.c:206:40: error: implicit declaration of function 'getpass' [-Wimplicit-function-declaration]
206 | if (!(unencrypted_password_s = getpass(PASSWORD_PROMPT))) {
This is because getpass in musl is guarded only for _GNU_SOURCE, so
define _GNU_SOURCE for run_init.
Signed-off-by: Robert Marko <[email protected]>
[Thomas: taken from OpenWrt at
https://git.infobricfleet.com/gtu/openwrt/-/blob/e56845fae3c05463a57ba8e0e104d6d8d8cd96ed/package/utils/policycoreutils/patches/0001-policycoreutils-run_init-define-_GNU_SOURCE.patch]
Signed-off-by: Thomas Petazzoni <[email protected]>
Contributor
Author
|
This is already fixed in main, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to compile run_init with musl will fail with: run_init.c: In function 'authenticate_via_shadow_passwd': run_init.c:206:40: error: implicit declaration of function 'getpass' [-Wimplicit-function-declaration]
206 | if (!(unencrypted_password_s = getpass(PASSWORD_PROMPT))) {
This is because getpass in musl is guarded only for _GNU_SOURCE, so define _GNU_SOURCE for run_init.
[Thomas: taken from OpenWrt at
https://git.infobricfleet.com/gtu/openwrt/-/blob/e56845fae3c05463a57ba8e0e104d6d8d8cd96ed/package/utils/policycoreutils/patches/0001-policycoreutils-run_init-define-_GNU_SOURCE.patch]