Skip to content

[dotnet] Remove deprecated DevTools capabilities from Firefox options #16047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Jul 12, 2025

User description

💥 What does this PR do?

As I remember Firefox doesn't support CDP.

🔧 Implementation Notes

Just remove any mentions about DevTools in Firefox Options class.

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Other


Description

  • Remove deprecated DevTools capabilities from Firefox options

  • Clean up Firefox driver configuration classes

  • Remove EnableDevToolsProtocol property and related constants


Changes diagram

flowchart LR
  A["FirefoxOptions class"] -- "remove" --> B["EnableDevToolsProtocol property"]
  A -- "remove" --> C["DevTools capability constant"]
  A -- "remove" --> D["DevTools capability registration"]
  E["Test configuration classes"] -- "remove" --> F["EnableDevToolsProtocol usage"]
Loading

Changes walkthrough 📝

Relevant files
Cleanup
FirefoxOptions.cs
Remove DevTools protocol support from Firefox options       

dotnet/src/webdriver/Firefox/FirefoxOptions.cs

  • Remove FirefoxEnableDevToolsProtocolCapability constant
  • Remove EnableDevToolsProtocol property and its documentation
  • Remove DevTools capability registration in constructor
  • Remove DevTools capability setting in ToCapabilities() method
  • +0/-11   
    NightlyChannelFirefoxDriver.cs
    Clean up nightly Firefox driver configuration                       

    dotnet/test/common/CustomDriverConfigs/NightlyChannelFirefoxDriver.cs

    • Remove EnableDevToolsProtocol = true from default options
    +1/-1     
    StableChannelFirefoxDriver.cs
    Clean up stable Firefox driver configuration                         

    dotnet/test/common/CustomDriverConfigs/StableChannelFirefoxDriver.cs

    • Remove EnableDevToolsProtocol = true from default options
    +1/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-dotnet .NET Bindings label Jul 12, 2025
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    Removing the EnableDevToolsProtocol property is a breaking change that could affect existing code using this property. Consider deprecation warnings or version compatibility documentation.

    public string? BrowserExecutableLocation
    {
        get => this.BinaryLocation;
        set => this.BinaryLocation = value;
    }
    
    /// <summary>
    /// Gets or sets the logging level of the Firefox driver.
    /// </summary>
    public FirefoxDriverLogLevel LogLevel { get; set; } = FirefoxDriverLogLevel.Default;
    
    /// <summary>
    /// Gets or sets the options for automating Firefox on Android.
    /// </summary>
    public FirefoxAndroidOptions? AndroidOptions { get; set; }

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @diemol
    Copy link
    Member

    diemol commented Jul 14, 2025

    Yes, this was already removed from other bindings, I believe.

    Copy link
    Member Author

    @nvborisenko nvborisenko left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Let's move on with standard deprecation policy.

    @nvborisenko
    Copy link
    Member Author

    Strange, I found moz:debuggerAddress mentions in py/js/java/rb. So everybody missed this deprecation or I understand this capability incorrectly.

    @nvborisenko
    Copy link
    Member Author

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants