[dotnet] [bidi] Preserve BiDi global options when instantiating BiDi #16080
+25
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
It will be used to setting some global options, like command timeout (30 secs by default as for now).
💥 What does this PR do?
Preserving method signature for further improvements without any breaking changes.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Add
BiDiOptions
class for future BiDi configurationUpdate
AsBiDiAsync
method to accept optional BiDi optionsPreserve method signature for backwards compatibility
Diagram Walkthrough
File Walkthrough
BiDiOptions.cs
Create BiDiOptions configuration class
dotnet/src/webdriver/BiDi/BiDiOptions.cs
BiDiOptions
sealed classWebDriver.Extensions.cs
Update AsBiDiAsync method signature
dotnet/src/webdriver/BiDi/WebDriver.Extensions.cs
BiDiOptions
parameter toAsBiDiAsync
method