AspNetCore: Add automatic configuration#86
Open
natehitze wants to merge 1 commit intoSumoLogic:masterfrom
Open
AspNetCore: Add automatic configuration#86natehitze wants to merge 1 commit intoSumoLogic:masterfrom
natehitze wants to merge 1 commit intoSumoLogic:masterfrom
Conversation
natehitze
changed the title
Contributor
guptakeshav-sumo
left a comment
guptakeshav-sumo
left a comment
There was a problem hiding this comment.
Can you please give a little more context on what are we trying to achieve by support for pulling configuration from DI?
|
|
||
| public LoggerProvider(IOptionsMonitor<LoggerOptions> options) | ||
| { | ||
| optionsReloadToken = options.OnChange(ReConfig); |
Contributor
There was a problem hiding this comment.
optionsReloadDisposable / optionsOnChangeDisposable or something like that?
Author
There was a problem hiding this comment.
Are you asking for the variable to be renamed?
|
|
||
| public LoggerProvider(IOptionsMonitor<LoggerOptions> options) | ||
| { | ||
| optionsReloadToken = options.OnChange(ReConfig); |
Contributor
There was a problem hiding this comment.
ReConfig isn't a thread-safe method. Perhaps we need to make it thread-safe now?
Author
|
Pulling configuration from DI allows us to use core's configuration system. For instance in dev I use See #87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for pulling configuration from DI. Also adds support for options reconfiguration.
Based on ConsoleLogger: https://github.com/aspnet/Extensions/tree/2.2.0/src/Logging/Logging.Console/src