WIP: capture gcc-14 fixes for binutils #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmecher
commented
Jul 16, 2025
|
|
||
| opcode->inst_type=INST_TYPE_RD_R1_IMML; | ||
| - opcode->inst_offset_type = OPCODE_MASK_H; | ||
| + opcode->inst_offset_type = 0; /* FIXME OPCODE_MASK_H; */ |
There was a problem hiding this comment.
This is a "short" field getting a 32-bit-long constant. The gcc-14 error, above, tells me it's truncating to 0. For the time being, I'm just making that truncation explicit. (See? I told you not to merge this patch.)
gsmecher
commented
Jul 16, 2025
| } | ||
| if (strcmp (op_end, "")) | ||
| - op_end = parse_reg (op_end + 1, &immed); /* Get rfslN. */ | ||
| + op_end = parse_reg (op_end + 1, (unsigned *)&immed); /* Get rfslN. */ |
There was a problem hiding this comment.
Similarly, immed is long long (i.e. at least 64 bits), and parse_reg expects a pointer to a 32-bit quantity. Assuming we're on a little-endian system, it's a bad-but-seemingly-functional idea to cast between them like this. On a big-endian system it would certainly not work as expected.
|
FWIW Bumped into the same build errors on Debian 13, these patches fix the build issues. Can these be reworked towards a version that is mergeable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binutils patches carried in meta-xilinx/meta-microblaze/recipes-devtools/binutils do not build when using gcc-14. This patch series contains two kinds of things:
Item (1) needs review, but item (2) needs some care and attention. This PR is not meant to be merged wholesale.
The patches themselves contain build error messages in fairly excruciating detail.