Fixes builds for Debian Linux ARM and gcc 12#82
Open
jcampbell05 wants to merge 7 commits intoadobe:mainfrom
Open
Fixes builds for Debian Linux ARM and gcc 12#82jcampbell05 wants to merge 7 commits intoadobe:mainfrom
jcampbell05 wants to merge 7 commits intoadobe:mainfrom
Conversation
…lag which isn't supported by compilers in this environment.
-m64 flag which isn't supported
added 6 commits
August 25, 2023 13:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously when compiling under these architectures on Debian Linux with gcc 12 the build script would fail, this PR fixes the reasons for these errors.
Related Issue
#81
Motivation and Context
Currently you cannot build on Linux ARM based systems for the following reasons:
-m64flag when building on a 64-bit system, but GCC on ARM doesn't support this flag. So we no longer emit it when building. for ARM.libsspbut GCC for ARM isn't compiled with this and it doesn't respect theXMP_ENABLE_SECURE_SETTINGSsetting in build/shared/ToolchainGCC.cmake. The Cmakefile now respects this setting for Linux allowing us to disable the use oflibsspand resolve these errors on ARM.How Has This Been Tested?
After making this change I was able to initiate a build without getting the
gccerror.Types of changes
Checklist: