Skip to content

Conversation

@Dreamsorcerer
Copy link
Member

Fixes for CodeQL errors that have randomly started appearing in a PR.

@Dreamsorcerer Dreamsorcerer changed the title CodeQL fixes Make BaseSerializer abstract Jan 2, 2023
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #624 (f819bee) into master (1b839ab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files          36       36              
  Lines        3557     3551       -6     
==========================================
- Hits         3545     3539       -6     
  Misses         12       12              
Flag Coverage Δ
unit 99.66% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiocache/serializers/serializers.py 95.45% <100.00%> (+0.06%) ⬆️
tests/acceptance/test_serializers.py 100.00% <100.00%> (ø)
tests/ut/test_serializers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0482773...f819bee. Read the comment docs.

@Dreamsorcerer
Copy link
Member Author

Probably a breaking change for some people, so pushing to next release.

@Dreamsorcerer Dreamsorcerer added this to the 1.0 milestone Jan 2, 2023
@Dreamsorcerer Dreamsorcerer merged commit d2d91c3 into master Jan 13, 2023
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-4 branch January 13, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants