Skip to content

Conversation

@elbaro
Copy link

@elbaro elbaro commented Jan 7, 2025

What do these changes do?

Are there changes in behavior for the user?

Related issue number

#431

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Dreamsorcerer
Copy link
Member

I'm pretty sure you're correct, but I'm a little confused with why codecov says the line is fully covered already:
https://app.codecov.io/gh/aio-libs/aiomcache/blob/master/aiomcache%2Fclient.py#L333

@elbaro
Copy link
Author

elbaro commented Jan 14, 2025

Not sure how codecov works but the line (L333) is covered and it's probably one statement even if some expressions are not visited.
Is there anything else required to merge this?

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Jan 14, 2025

Not sure how codecov works but the line (L333) is covered and it's probably one statement even if some expressions are not visited.

It has branch coverage, so if the condition was always True, then it'd be highlighted yellow to show the line only has partial coverage. That's the bit that confuses me. It's probably fine though, might just be a hiccup with the coverage tool.

@elbaro
Copy link
Author

elbaro commented Jan 16, 2025

For anyone who needs this patch, use a fork pip install aiomcache-pr432.

@elbaro elbaro closed this Jan 16, 2025
@Dreamsorcerer Dreamsorcerer reopened this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants