Use select.poll instead of select.select to support fds higher than 1024#668
Open
nivye wants to merge 1 commit intoaio-libs:masterfrom
Open
Use select.poll instead of select.select to support fds higher than 1024#668nivye wants to merge 1 commit intoaio-libs:masterfrom
nivye wants to merge 1 commit intoaio-libs:masterfrom
Conversation
8f597ab to
caff13b
Compare
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 10 10
Lines 1037 1037
Branches 121 121
=======================================
Hits 956 956
Misses 65 65
Partials 16 16 Continue to review full report at Codecov.
|
caff13b to
2b91d4e
Compare
2b91d4e to
c7536f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select.select has a known issue in which it throws a ValueError exception for file descriptors higher than 1024 (similar issue at https://bugs.python.org/issue31610)
This change does not introduce any API changes and does not introduce any new behavior.
It solely replaces select.select by select.poll to be able to support file descriptors larger than 1024.
Also added a test to demonstrate the fix - replacing the new select.poll code portion by the previous select.select line, would raise a ValueError when handling the OperationalError.