feat(cicd): codspeed benchmarks#688
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 96.88% 97.22% +0.34%
==========================================
Files 12 12
Lines 770 793 +23
Branches 91 41 -50
==========================================
+ Hits 746 771 +25
+ Misses 22 20 -2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
Update, I moved the benchmarks out of the test suite so they don't run with the regular tests. This should fix everything. |
|
Thanks for the review, I've committed your suggestion and replied to your other comment. |
|
Hmmm, what happened here? |
|
Looks like its getting closer |
|
woohoo, finally! are you able to create a |
|
I don’t have the necessary permissions to install it, so I’ll ask one of my colleagues to handle it. |
|
codspeed and token added. close/reopen to restart ci |
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
|
benchmarks are up. Probably need a few tweaks to make sure we are measuring more of the lib instead of asyncio |
|
I started to update the benchmarks by converting them into batched jobs, but after doing the first 3 I noticed there is a lot of stuff from what appears to be pytest-cov in the flamegraphs I've just disabled pytest-cov for the benchmark runner, let's take a look at the outputs once the benchmarks run again and see if we still need to tweak them further |
|
Turns out they were from an unrelated I've now disabled both |
do you think the addition of batching and the internal sync microbenchmarks is suffcient to address your concern here? I can't think of any other strategies we might use to minimize the asyncio stuff in the flamegraphs because of how integrated everything is. |
0725ac5 to
10bb7e7
Compare
10bb7e7 to
5c25a0b
Compare
|
I'm traveling until Wednesday night. I'll take a peek at the last turn when I get back home. |
What do these changes do?
This PR adds codspeed benchmarks for various scenarios
Are there changes in behavior for the user?
N/A
Related issue number
N/A
Checklist