impl OPENSSL_SRC_PREFIX_SANTIZE env var#165
Open
ShootingKing-AM wants to merge 2 commits intoalexcrichton:mainfrom
Open
impl OPENSSL_SRC_PREFIX_SANTIZE env var#165ShootingKing-AM wants to merge 2 commits intoalexcrichton:mainfrom
ShootingKing-AM wants to merge 2 commits intoalexcrichton:mainfrom
Conversation
- Sanitize path forcefully based on env var - Dump some helpful build info when build fails
Owner
|
Thanks for this PR, but is there a need for this to be an env var? Can this be automatically detected when this sanitization on Windows is required? |
Author
|
Actually I also thought so, but i dont know all kinds of cases people use this crate in. So thought I wouldn't want to make any breaking changes. Otherwise, we can enforce some consistency with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.