Skip to content

chore: move deps to workspace #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joe-p wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: move deps to workspace #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bd046f
chore: move serde deps to workspace
joe-p Feb 1, 2026
d4dcb7d
chore: more workspace deps
joe-p Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ snafu = { version = "0.8" }
base32 = { version = "0.5.1" }
sha2 = { version = "0.10.8" }
rstest = { version = "0.25.0" }
serde = { version = "1.0.216", features = ["derive"] }
serde_with = { version = "3.11.0", default-features = false, features = ["base64", "std", "macros"] }
serde_json = { version = "1.0.133" }
serde_repr = { version = "0.1.20" }
serde_bytes = { version = "0.11.15" }
rmp = { version = "0.8.12" }
rmp-serde = { version = "1.3.0" }
rmpv = { version = "1.3.0", features = ["with-serde"] }
base64 = { version = "0.22.1" }
url = { version = "2.5" }
uuid = { version = "1.0", features = ["v4"] }
convert_case = { version = "0.8.0" }

[workspace.metadata.bin]
polytest = { version = "0.3.0", locked = true }
Expand Down
24 changes: 10 additions & 14 deletions api/oas_generator/rust_oas_generator/templates/base/Cargo.toml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,15 @@ ffi_uniffi = ["dep:uniffi", "algokit_http_client/ffi_uniffi", "dep:algokit_trans

[dependencies]
# Core serialization
serde = { version = "^1.0", features = ["derive"] }
serde_with = { version = "^3.8", default-features = false, features = [
"base64",
"std",
"macros",
] }
serde_json = "^1.0"
serde_repr = "^0.1"
serde_bytes = "^0.11"
serde = { workspace = true }
serde_with = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_bytes = { workspace = true }

# HTTP client
algokit_http_client = { path = "../algokit_http_client", features = ["ffi_uniffi"] }
url = "^2.5"
url = { workspace = true }

# Uniffi for FFI bindings
uniffi = { workspace = true, optional = true }
Expand All @@ -35,16 +31,16 @@ algokit_transact_ffi = { optional = true, version = "0.1.0", path = "../algokit_
# AlgoKit dependencies for msgpack and signed transactions
algokit_transact = { path = "../algokit_transact" }
# MessagePack serialization
rmp-serde = "^1.1"
rmpv = { version = "1.3.0", features = ["with-serde"] }
rmp-serde = { workspace = true }
rmpv = { workspace = true }
{% endif %}

# Error handling
snafu = { workspace = true }

# Utilities
base64 = "^0.22"
uuid = { version = "^1.0", features = ["v4"] }
base64 = { workspace = true }
uuid = { workspace = true }

[dev-dependencies]
tokio = { version = "1.0", features = ["full"] }
Expand Down
24 changes: 10 additions & 14 deletions crates/algod_client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,15 @@ ffi_uniffi = ["dep:uniffi", "algokit_http_client/ffi_uniffi", "dep:algokit_trans

[dependencies]
# Core serialization
serde = { version = "^1.0", features = ["derive"] }
serde_with = { version = "^3.8", default-features = false, features = [
"base64",
"std",
"macros",
] }
serde_json = "^1.0"
serde_repr = "^0.1"
serde_bytes = "^0.11"
serde = { workspace = true }
serde_with = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_bytes = { workspace = true }

# HTTP client
algokit_http_client = { path = "../algokit_http_client", features = ["ffi_uniffi"] }
url = "^2.5"
url = { workspace = true }

# Uniffi for FFI bindings
uniffi = { workspace = true, optional = true }
Expand All @@ -34,15 +30,15 @@ algokit_transact_ffi = { optional = true, version = "0.1.0", path = "../algokit_
# AlgoKit dependencies for msgpack and signed transactions
algokit_transact = { path = "../algokit_transact" }
# MessagePack serialization
rmp-serde = "^1.1"
rmpv = { version = "1.3.0", features = ["with-serde"] }
rmp-serde = { workspace = true }
rmpv = { workspace = true }

# Error handling
snafu = { workspace = true }

# Utilities
base64 = "^0.22"
uuid = { version = "^1.0", features = ["v4"] }
base64 = { workspace = true }
uuid = { workspace = true }

[dev-dependencies]
tokio = { version = "1.0", features = ["full"] }
Expand Down
6 changes: 3 additions & 3 deletions crates/algokit_abi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ num-bigint = "0.4"
regex = "1.0"
base32 = { workspace = true }
sha2 = { workspace = true }
serde = { version = "1.0.216", features = ["derive"] }
serde_json = "1.0.133"
base64 = "0.21"
serde = { workspace = true }
serde_json = { workspace = true }
base64 = { workspace = true }
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change upgrades base64 from version 0.21 to 0.22.1. While this aligns with the base64 0.22 API already used in the code (Engine trait and general_purpose), this version upgrade should be explicitly mentioned in the PR description since it goes beyond just "moving deps to workspace". The base64 0.22 release included breaking API changes, so this upgrade should be intentional and tested.

Suggested change
base64 = { workspace = true }
base64 = "0.22.1"

Copilot uses AI. Check for mistakes.
algokit_test_artifacts = { path = "../algokit_test_artifacts" }

[dev-dependencies]
Expand Down
2 changes: 1 addition & 1 deletion crates/algokit_http_client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ default_client = ["dep:reqwest"]
[dependencies]
async-trait = "0.1.88"
reqwest = { version = "0.12.19", optional = true }
serde = { version = "1.0", features = ["derive"] }
serde = { workspace = true }
snafu = { workspace = true }
uniffi = { workspace = true, optional = true }
22 changes: 11 additions & 11 deletions crates/algokit_transact/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ test_utils = [

[dependencies]
base32 = { workspace = true }
base64 = "0.22.1"
convert_case = { version = "0.8.0", optional = true }
base64 = { workspace = true }
convert_case = { workspace = true, optional = true }
derive_builder = { version = "0.20.2" }
ed25519-dalek = { version = "2.1.1", optional = true }
rmp = "0.8.12"
rmp-serde = "1.3.0"
rmpv = { version = "1.3.0", features = ["with-serde"] }
serde = { version = "1.0.216", features = ["derive"] }
serde_bytes = "0.11.12"
serde_json = "1.0.133"
serde_repr = "0.1.20"
serde_with = "3.11.0"
rmp = { workspace = true }
rmp-serde = { workspace = true }
rmpv = { workspace = true }
serde = { workspace = true }
serde_bytes = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_with = { workspace = true }
sha2 = { workspace = true }
snafu = "0.8"
snafu = { workspace = true }
algokit_test_artifacts = { path = "../algokit_test_artifacts", optional = true }

[dev-dependencies]
Expand Down
18 changes: 9 additions & 9 deletions crates/algokit_transact_ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ algokit_transact = { path = "../algokit_transact", features = ['test_utils'] }
ffi_macros = { path = "../ffi_macros" }

snafu = "0.8"
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snafu dependency should be changed to use workspace inheritance for consistency with other crates. All other crates in this PR use snafu = { workspace = true }, but this file still has snafu = "0.8". This inconsistency makes it harder to manage the snafu version across the workspace.

Copilot uses AI. Check for mistakes.
rmp-serde = "1.3.0"
serde = { version = "1.0.216", features = ["derive"] }
serde_bytes = "0.11.15"
serde_json = "1.0.133"
base64 = "0.22.1"
rmp-serde = { workspace = true }
serde = { workspace = true }
serde_bytes = { workspace = true }
serde_json = { workspace = true }
base64 = { workspace = true }

uniffi = { workspace = true, features = [
"scaffolding-ffi-buffer-fns",
Expand All @@ -37,7 +37,7 @@ uniffi = { workspace = true, features = [
algokit_transact = { path = "../algokit_transact", features = ['test_utils'] }
ffi_macros = { path = "../ffi_macros" }
snafu = "0.8"
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snafu dependency in build-dependencies should also be changed to use workspace inheritance for consistency with other crates. This is the same issue as in the [dependencies] section - all other crates use snafu = { workspace = true }.

Copilot uses AI. Check for mistakes.
serde = { version = "1.0.216", features = ["derive"] }
serde_bytes = "0.11.15"
serde_json = "1.0.133"
base64 = "0.22.1"
serde = { workspace = true }
serde_bytes = { workspace = true }
serde_json = { workspace = true }
base64 = { workspace = true }
2 changes: 1 addition & 1 deletion crates/ffi_macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ edition = "2024"
proc-macro = true

[dependencies]
convert_case = "0.8.0"
convert_case = { workspace = true }
quote = "1.0.39"
syn = "2.0.99"
20 changes: 8 additions & 12 deletions crates/indexer_client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,15 @@ ffi_uniffi = ["dep:uniffi", "algokit_http_client/ffi_uniffi", "dep:algokit_trans

[dependencies]
# Core serialization
serde = { version = "^1.0", features = ["derive"] }
serde_with = { version = "^3.8", default-features = false, features = [
"base64",
"std",
"macros",
] }
serde_json = "^1.0"
serde_repr = "^0.1"
serde_bytes = "^0.11"
serde = { workspace = true }
serde_with = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_bytes = { workspace = true }

# HTTP client
algokit_http_client = { path = "../algokit_http_client", features = ["ffi_uniffi"] }
url = "^2.5"
url = { workspace = true }

# Uniffi for FFI bindings
uniffi = { workspace = true, optional = true }
Expand All @@ -36,8 +32,8 @@ algokit_transact_ffi = { optional = true, version = "0.1.0", path = "../algokit_
snafu = { workspace = true }

# Utilities
base64 = "^0.22"
uuid = { version = "^1.0", features = ["v4"] }
base64 = { workspace = true }
uuid = { workspace = true }

[dev-dependencies]
tokio = { version = "1.0", features = ["full"] }
Expand Down
20 changes: 8 additions & 12 deletions crates/kmd_client/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,15 @@ ffi_uniffi = ["dep:uniffi", "algokit_http_client/ffi_uniffi", "dep:algokit_trans

[dependencies]
# Core serialization
serde = { version = "^1.0", features = ["derive"] }
serde_with = { version = "^3.8", default-features = false, features = [
"base64",
"std",
"macros",
] }
serde_json = "^1.0"
serde_repr = "^0.1"
serde_bytes = "^0.11"
serde = { workspace = true }
serde_with = { workspace = true }
serde_json = { workspace = true }
serde_repr = { workspace = true }
serde_bytes = { workspace = true }

# HTTP client
algokit_http_client = { path = "../algokit_http_client", features = ["ffi_uniffi"] }
url = "^2.5"
url = { workspace = true }

# Uniffi for FFI bindings
uniffi = { workspace = true, optional = true }
Expand All @@ -36,8 +32,8 @@ algokit_transact_ffi = { optional = true, version = "0.1.0", path = "../algokit_
snafu = { workspace = true }

# Utilities
base64 = "^0.22"
uuid = { version = "^1.0", features = ["v4"] }
base64 = { workspace = true }
uuid = { workspace = true }

[dev-dependencies]
tokio = { version = "1.0", features = ["full"] }
Expand Down