build(android): preliminary Android support for algokit_transact #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: build errors from latest main changes
fix: change sample app function reference
wip: android test with README
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces preliminary Kotlin/Android support for algokit_transact by adding build infrastructure and test coverage. The changes include a new Kotlin build module, updates to existing Swift FFI bindings to reflect API changes, and refactoring of error message field names from message to error_msg across the Rust codebase.
- New Kotlin build support with Android-specific configurations
- Refactored error handling field naming for consistency
- Updated Swift package tests to align with API changes
Reviewed Changes
Copilot reviewed 45 out of 59 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/build_pkgs/src/kotlin.rs | New build script for Kotlin/Android packages with multi-target compilation |
| tools/build_pkgs/src/main.rs | Added Kotlin language variant and integrated kotlin build module |
| tools/build_pkgs/src/python.rs | Updated to use new dylib(None) signature |
| packages/android/algokit_transact/* | New Gradle-based Android library with unit and instrumented tests |
| crates/algokit_transact_ffi/src/lib.rs | Renamed error field from message to error_msg |
| crates/algokit_transact/src/error.rs | Renamed error message field for consistency |
| packages/swift/AlgoKitTransact/* | Updated tests and FFI headers to reflect API changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joe-p
changed the title
joe-p
changed the title
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
Closes #291
See the README in packages/android/algokit_transact for build and test steps.
Note that this PR is specifically targeted towards android and building an AAR. In the future we eventually should publish a multi-platform package for algokit_transact on maven central.
Will need #292 to merge first