feat: code signing and integration with CrabNebula#375
Merged
PatrickDinh merged 1 commit intomainfrom Jan 22, 2025
Merged
Conversation
Deploying algokit-lora with
|
| Latest commit: |
b8720be
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d1564f22.algokit-lora.pages.dev |
| Branch Preview URL: | https://code-signing.algokit-lora.pages.dev |
PatrickDinh
force-pushed
the
code-signing
branch
2 times, most recently
from
81a3bad to
5ead859
Compare
neilcampbell
approved these changes
Jan 17, 2025
Contributor
neilcampbell
left a comment
neilcampbell
left a comment
There was a problem hiding this comment.
@lempira We've added the lora web favicon as the app icon. Not sure if we want to use something else?
@PatrickDinh Are all those icons used? Looks like some are newly added ones that may not be used?
lempira
reviewed
Jan 21, 2025
Contributor
@neilcampbell, Nope that's good. I had made that change in another PR with the code signing, but it never got merged. I used the same Icon. |
lempira
approved these changes
Jan 22, 2025
Contributor
lempira
left a comment
lempira
left a comment
There was a problem hiding this comment.
THanks for the answers to the questions
- code signing - release to CrabNebula - update icons
PatrickDinh
force-pushed
the
code-signing
branch
from
74fabe6 to
b8720be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feat:
Note:
I'll reach out to Tauri team to ask if they support code signing + auto update forWe agreed that initially we support AppImage for Linux..devand.rpmon Linux.