Conversation
Contributor
Author
|
The preview apps don't seem to be deploying (looking into that). Was going to link the preview app, but I took a screenshot. How does does this look to you @larkiny ? 
|
larkiny
approved these changes
Jan 16, 2025
Contributor
Author
|
I realized the color for the heartbeat txn was the same as keyreg. I choose a green color for heartbeat since green is alive. 
|
Deploying algokit-lora with
|
| Latest commit: |
64c8239
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65c34c4f.algokit-lora.pages.dev |
| Branch Preview URL: | https://heartbeat-spike.algokit-lora.pages.dev |
Contributor
Author
|
Ok, the third time is the charm. I got the current color in Lora and checked with @larkiny, and decided on a brighter yellow. Current color in Lora
dark 
light 
|
lempira
force-pushed
the
heartbeat-spike
branch
from
a0c6d17 to
64c8239
Compare
neilcampbell
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am PRing @neilcampbell spike on adding heartbeat txn type. There were some
TODO HBbut it looks like they have been defined. I am guessing it's just a matter of getting the approval from product @larkiny