Fix/dispenser failures in locale #565
Merged
+122
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ian locales Spanish (es-ES), Portuguese (pt-PT), and Italian (it-IT) only apply thousand grouping for numbers ≥10,000. Using 1000 caused the function to fall back to comma, creating a separator collision error in forms. - Change getThousandSeparator to use 10000 instead of 1000 - Add defensive validation in NumericFormat component - Add comprehensive test coverage for es-ES locale - Add integration test for Spanish locale in dispenser
neilcampbell
approved these changes
Feb 13, 2026
engineering-ci bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
## [2.3.2-beta.1](v2.3.1...v2.3.2-beta.1) (2026-02-13) ### 🐛 Bug Fixes * correct thousand separator detection for certain locales ([#565](#565)) ([242337e](242337e))
engineering-ci bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
## [2.3.2](v2.3.1...v2.3.2) (2026-02-13) ### 🐛 Bug Fixes * correct thousand separator detection for certain locales ([#565](#565)) ([242337e](242337e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564
This PR fixes a critical bug preventing users with Spanish, Portuguese (Portugal), or Italian browser locales from accessing the testnet dispenser due to a number formatting separator collision error.
The issue stemmed from using 1000 to detect thousand separators, but these locales only apply thousand grouping for numbers ≥10,000. This caused the thousand separator detection to fall back to comma, which conflicted with the comma decimal separator, triggering the error "Decimal separator can't be same as thousand separator". The fix updates the detection to use 10000 instead, ensuring proper grouping appears in all locales. Additional defensive validation was added to the NumericFormat component as a safety net against future locale detection edge cases.
Comprehensive test coverage for Spanish locale was added to both unit and integration tests to prevent regression. A maintenance commit also updates the .nsprc file to reflect changes in npm audit vulnerability IDs.
Before fix when navigating to
http://localhost:5173/testnet/fundAfter fix
