Fixes for box population and errors from a rejected app call transaction

[daniel-makerx]

No description provided.

[robdmoore]

If these exceptions surface will it be confusing to developers, i.e. "Error resolving execution" -> "Why is it trying to "resolve execution, what does that mean?", or will these exceptions be clear that they are raised as part of resolving an error in a call?

[robdmoore]

(Ah I see these are the existing error messages anyway, although the question still stands).

[daniel-makerx]

They will be transformed into a LogicError (in the client error handling) which should map it to the appropriate TEAL or error message if they have an app spec

[neilcampbell]

Previously (on the TS side) this error was specific to resource population (Error populating resources...). When we added fee coverage support, the auto simulate behaviour would execute for that scenario too, so the error needed to be more generic.

[github-actions]

Coverage Report

File	Stmts	Miss	Cover	Missing
src/algokit_utils
_debugging.py	141	18	87%	21, 40–42, 45, 54, 62, 81, 87, 96, 110–114, 133, 141–143
account.py	3	3	0%	1–12
algorand.py	105	14	87%	66–67, 81–82, 112–113, 140–141, 176–177, 321, 344, 360, 379
application_client.py	3	3	0%	1–11
application_specification.py	7	7	0%	1–39
config.py	78	29	63%	23, 30–34, 73–74, 90, 95, 100, 111–116, 140–156
deploy.py	3	3	0%	1–10
logic_error.py	3	3	0%	1–10
src/algokit_utils/_legacy_v2
_ensure_funded.py	72	1	99%	96
_transfer.py	72	3	96%	14, 77–78
account.py	93	13	86%	15–18, 71–75, 109, 126, 156, 159, 203
application_client.py	537	77	86%	56–57, 176, 181, 210, 320, 325–326, 328, 330, 799, 814, 832–835, 929, 969, 981, 994, 1036, 1096–1102, 1106–1111, 1113, 1149, 1156, 1269, 1305, 1319, 1357–1359, 1361, 1371–1428, 1439–1444, 1464–1467
asset.py	80	4	95%	24–27
common.py	13	1	92%	13
deploy.py	407	22	95%	32–35, 170, 174–175, 193, 249, 339–340, 361, 395, 406–414, 429, 437, 593–594, 618
network_clients.py	73	5	93%	79–80, 105–106, 139
src/algokit_utils/accounts
account_manager.py	255	39	85%	167, 183–184, 211–216, 295–305, 339–344, 391–393, 422, 461, 481–485, 498, 557, 578, 735, 841, 920, 925, 940–941, 964
kmd_account_manager.py	73	10	86%	47–53, 94, 150, 157
src/algokit_utils/applications
abi.py	139	69	50%	14, 75, 111, 117, 119, 121, 141–160, 176, 179–185, 201–214, 227–239, 254–265
app_client.py	773	231	70%	66–74, 136, 144, 331–334, 337, 340, 343, 346, 358–361, 364, 367, 370, 373, 385, 394, 403, 406–468, 481–539, 563–565, 582–585, 593–596, 604–607, 615–618, 626–629, 640–643, 656, 752–755, 789, 801, 813, 825, 837, 852, 867, 877, 887, 897, 907, 917, 954–967, 983, 1000, 1017, 1034, 1055, 1076, 1166, 1222, 1363, 1427–1428, 1477, 1479, 1485, 1538–1546, 1579–1582, 1585–1588, 1609, 1657, 1720–1722, 1735–1746, 1791, 1808, 1810, 1813, 1817, 1964–1983, 2013, 2026–2028, 2032, 2043–2044, 2072, 2082–2084, 2087–2109, 2119, 2128–2143, 2148–2153
app_deployer.py	237	37	84%	96, 270, 277, 287–292, 295–299, 375–376, 591, 603–617, 629, 634–637, 646, 660, 667, 674, 703, 714–755
app_factory.py	271	27	90%	430, 451, 460, 652, 662, 712, 944, 958–963, 974–975, 1008, 1046, 1064–1065, 1108, 1116–1129
app_manager.py	223	18	92%	258, 279–280, 350–351, 396–401, 433, 457–458, 488, 516–519, 551, 560
src/algokit_utils/applications/app_spec
arc32.py	95	8	92%	198–207
arc56.py	578	19	97%	171, 292, 308–309, 379, 399–401, 453, 462, 464, 736, 750, 909, 911, 968, 970–971, 987
src/algokit_utils/assets
asset_manager.py	128	12	91%	282–283, 292, 298–322, 332
src/algokit_utils/clients
client_manager.py	178	54	70%	24–26, 79–86, 111, 143–145, 205, 216–219, 244, 283, 318–323, 358–360, 393, 410, 432, 477–480, 520–523, 564–567, 604–607, 629–654, 692, 705, 717
dispenser_api_client.py	96	12	88%	134–135, 139–142, 198–200, 219–221
src/algokit_utils/errors
logic_error.py	56	11	80%	14, 105–121
src/algokit_utils/models
account.py	92	15	84%	32, 34, 80–81, 128, 136, 144, 168–175, 188, 196, 209, 217
amount.py	106	17	84%	35, 42, 88, 98, 104, 112, 117–119, 126, 131–133, 140, 147, 160, 166
application.py	66	1	98%	8
state.py	41	5	88%	61, 65–68
transaction.py	51	3	94%	66, 86, 91
src/algokit_utils/protocols
account.py	11	2	82%	17, 22
typed_clients.py	24	4	83%	12–24
src/algokit_utils/transactions
transaction_composer.py	1145	114	90%	35–39, 91, 101–105, 599, 644, 647, 652, 656–667, 700, 729, 774–775, 779–780, 839, 846, 868, 907, 1004–1033, 1062, 1090–1105, 1110, 1118, 1120, 1122, 1138, 1144, 1182, 1190, 1299, 1349, 1433, 1435–1436, 1829–1830, 1869–1870, 1911, 2124, 2127, 2146, 2151, 2179–2181, 2222–2258, 2265–2272, 2414, 2418, 2551, 2553–2554, 2604–2605
transaction_creator.py	75	7	91%	394, 427, 482, 520, 557, 590, 688
transaction_sender.py	161	10	94%	101, 270, 313–314, 712–717, 722–723, 888
TOTAL	6792	931	86%

Tests	Skipped	Failures	Errors	Time
419	0 💤	0 ❌	0 🔥	3m 41s ⏱️

[robdmoore]

These changes presumably also need to be made to typescript utils too

[daniel-makerx]

These changes presumably also need to be made to typescript utils too

yeah the one that adds the PC does. The other was python specific