test: use polytest in transact #460
Open
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be noted that --no-parse is needed because polytest isn't properly handling the leading directory (test/) in the output
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates polytest into the transact package to enable cross-language testing. The integration uses polytest version 0.6.0 with a temporary workaround (--no-parse flag) to handle output parsing issues.
- Adds polytest npm scripts for generating and running tests
- Excludes polytest temporary directories from version control and test runners
- References a feature branch of polytest via git URL
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vitest.config.ts | Excludes .polytest* directories from vitest test discovery |
| packages/transact/package.json | Adds polytest:generate and polytest:run npm scripts |
| .gitignore | Ignores .polytest*/ temporary directories |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be noted that
--no-parseis needed for the run command because polytest isn't properly handling the leading directory (test/) in the output. This should eventually be fixed in polytest, but it's not critical for now because we can just rely on the vitest output since we are only running tests for one language.Note that this requires the latest polytest version: 0.6.0
algokit-polytest PR: algorandfoundation/algokit-polytest#10