Conversation
THis introduces a breaking change to AccountManager ctor
joe-p
force-pushed
the
decoupling-feat/crypto
branch
from
469ecef to
db17868
Compare
PatrickDinh
approved these changes
Jan 27, 2026
Contributor
PatrickDinh
left a comment
PatrickDinh
left a comment
There was a problem hiding this comment.
Not sure if you are planning to export this package or not. If you are, you will need to add an entry to rolldown
// Package re-exports
'src/abi/index.ts',
'src/algo25/index.ts',
'src/transact/index.ts',
'src/algod-client/index.ts',
'src/indexer-client/index.ts',
'src/kmd-client/index.ts',
| const xhd = new XHDWalletAPI() | ||
|
|
||
| export const peikertXHdWalletGenerator: HdWalletGenerator = async (seed?: Uint8Array) => { | ||
| const seedArray = seed ?? new Uint8Array(32) |
Contributor
There was a problem hiding this comment.
nitpick: looks like this var isn't needed, you can return
const rootKey = fromSeed(Buffer.from(seed === undefined ? newSeedBytes : new Uint8Array(32)))
Contributor
Author
There was a problem hiding this comment.
We need to intermediate seedArray because crypto.getRandomValues mutates the array. I was, however, able to get rid of the intermediate newSeedBytes in 1cab575
Contributor
|
🎉 This PR is included in version 10.0.0-alpha.33 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new
algokit-cryptopackage with interfaces and implementations of ed25519 and xHD account generation and signing. This is the only package in algokit that takes on crypto dependencies. The Algorand-specific logic in utils only works with the interfaces defined in this package and is agnostic to the underlying implementation.This PR also migrates from js-sha512 to @noble/hashes sha512