chore: bump UUID and remove types/UUID#21
Open
HashMapsData2Value wants to merge 1 commit intomainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage ? 71.62%
=======================================
Files ? 15
Lines ? 1991
Branches ? 167
=======================================
Hits ? 1426
Misses ? 564
Partials ? 1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ Overview
The UUID library past V11 has native typescript support and so there is no longer a need to import types/uuid.
https://www.npmjs.com/package/uuid
📝 Related Issues
The UUID library seems to be what is causing issues for Use-Wallet, resulting in Liquid Auth being temporarily removed. This might address that underlying issue.
Regardless, even if it doesn't, this is just following the UUID package's instructions.
✅ Acceptance:
npm test:covpasses