Conversation
If a node has disabled API Authentication, then algod.token doesn't exist, but genesis.json should always exist
feat: Added algod config to StateModel for displaying items in the UI
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #178 +/- ##
===========================================
+ Coverage 34.75% 45.35% +10.59%
===========================================
Files 89 93 +4
Lines 6974 5850 -1124
===========================================
+ Hits 2424 2653 +229
+ Misses 4417 2928 -1489
- Partials 133 269 +136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces P2P Hybrid mode configuration support to NodeKit, allowing users to configure their Algorand nodes to support P2P Hybrid connections. The implementation includes a new configuration interface, UI components to display and toggle the feature, and various cross-platform compatibility fixes.
Key Changes:
- Added P2P Hybrid mode configuration via
configure algodcommand with persistent storage inconfig.json - Implemented a modal UI component to inform users about P2P Hybrid mode availability
- Improved
algod.IsRunning()to check PID file existence rather than process name lookup for better reliability
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/algod/config/config.go | New config package defining P2P Hybrid mode settings |
| internal/algod/utils/utils.go | Added config read/write functions and hybrid popup state management |
| internal/algod/algod.go | Updated IsRunning to use PID-based process checking |
| cmd/configure/algod.go | New command for managing algod configuration options |
| ui/modals/hybrid/model.go | New modal component for P2P Hybrid mode information |
| ui/status.go | Updated status view to display P2P mode state |
| api/catchpoint.go | Changed error handling from string to error type |
| Multiple files | Import reorganization and filepath.Join adoption for cross-platform compatibility |
Comments suppressed due to low confidence (1)
internal/algod/utils/utils.go:1
- This change modifies the behavior of
FindPathToFileto check for file existence within each directory rather than checking if the path itself is a directory. The original code checkedos.Stat(path)to verifypathwas a directory before processing. Now it's checking iftargetFileNameexists inpath, which changes the function's semantics. This could break existing callers that expect directory validation.
package utils
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Tasos Bitsios <tasos.bitsios@algorand.foundation>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 33 out of 33 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mostly nil reference checks, most (if not all) would be impossible to happen, but better safe than sorry. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Closing in favour of #183 which includes all the same code plus some nice status UI tweaks. |
ℹ Overview
This PR add the ability to configure your algod node to support P2P Hybrid connections on the network.
It also adds a whole bunch of other tweaks and fixes I had to do whilst developing on MacOS.
Is it possible to release this as a beta version first? That way we can get some testing and feedback before the marketing push that gets everyone using it.
✅ Acceptance: