Conversation
cusma
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the xGov Registry “withdraw outstanding balance” flow so that the xGov Payor (instead of the xGov Manager) can withdraw a specified amount of the treasury’s available balance (excluding MBR and outstanding/governance funds).
Changes:
- Change
withdraw_balanceauthorization from xGov Manager to xGov Payor and add anamountparameter to the ABI method. - Update tests to call
withdraw_balance(amount=...)with the xGov Payor as sender and adjust assertions accordingly. - Update RBAC/treasury specs to reflect Payor treasury-management responsibility.
Reviewed changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/xgov_registry/test_withdraw_balance.py | Updates tests for the new withdraw_balance(uint64) signature and payor-only authorization. |
| smart_contracts/xgov_registry/contract.py | Adds is_xgov_payor() helper and updates withdraw_balance to be payor-only and amount-based. |
| smart_contracts/xgov_registry_mock/contract.py | Updates mock ABI signature for withdraw_balance(uint64). |
| smart_contracts/interfaces/xgov_registry.py | Updates interface signature for withdraw_balance(uint64). |
| smart_contracts/artifacts/xgov_registry_mock/XgovRegistryMock.approval.teal | Regenerated artifact reflecting the new ABI method signature. |
| smart_contracts/artifacts/xgov_registry/XGovRegistry.approval.teal | Regenerated artifact reflecting payor auth + new withdraw_balance(uint64) args parsing. |
| docs/specs/xgov-treasury.md | Documents Payor as the receiver for “Withdraw Outstanding Balance”. |
| docs/specs/xgov-rbac.md | Moves treasury-management withdrawal permission from Manager to Payor. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 14 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bwmx
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.