fix: no msig on disposable testnet deployment#399
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the xGov Registry “delete test deployment” path to avoid using Vault/multisig signing for disposable TestNet deployments, relying instead on the environment-provided deployer account.
Changes:
- Switch
_delete_test_deploymentto use theDEPLOYERaccount from environment for sender/signer. - Remove Vault-related environment variables from the GitHub Actions workflow that triggers test deployment deletion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
smart_contracts/xgov_registry/deploy_config.py |
Uses the environment deployer account directly for update/delete transactions during test deployment deletion. |
.github/workflows/xgov-beta-sc-delete-test-deployment.yml |
Removes Vault/multisig configuration from the delete-test-deployment workflow environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sofinico
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.