feat: enable CSV output #2754
Draft
feat: enable CSV output #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, CSV output is the same as table output, but with commas. Signed-off-by: Will Murphy <[email protected]>
wagoodman
reviewed
Jul 1, 2025
grype/presenter/csv/presenter.go
Outdated
There was a problem hiding this comment.
this is mostly a copy-paste of the table presenter. Are the display semantics similar enough to make the table presenter optionally output CSV?
There was a problem hiding this comment.
I don't know that they are. For example, we want to pretty print EPSS percents and percentiles, but in the CSV we probably want them to be separate columns and printed as bare floats?
wagoodman
reviewed
Jul 1, 2025
grype/presenter/csv/presenter.go
Outdated
|
|
||
| func (r row) Columns() []string { | ||
| columns := []string{ | ||
| stripANSI(r.Name), |
There was a problem hiding this comment.
why call the format functions then strip ansi characters? We could not call the format functions at all. Or have an alternative style set that is structural only without any ANSI control characters.
Previous draft of this feature included the csv format in its own present, but that is effectively just a copy of the table presenter with a different separation strategy. Therefore, combine the csv and table presenter so that if, for example, a new column needs to be added, it only needs to be done in one please. Signed-off-by: Will Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, CSV output is the same as table output, but with commas.