-
Notifications
You must be signed in to change notification settings - Fork 26
Implement step in and step out #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@stevedlawrence and/or @mbeckerle would you mind testing this update out? I am not fully confident if all the step functions behave as they should and would appreciate any feedback or assistance you can provide me. |
cc4a3e4 to
08f0cc8
Compare
|
I'll try to take a look this week. Can you describe what the intended behavior of stepIn, stepOut, and stepOver is? I know there's been discussions about it but I'm not sure what was finally decided on and want to make sure I'm on the same page when playing around with it. |
|
I basically tried to do what you had stated before in an email. I have it pasted here in issue #5. But basically:
I am not sure if there was anything formally decided, I mostly went with you had stated since you would know better how it could be done or what was possible with Daffoidl. |
lrbarber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my initial testing, there seems to be some disconnect between the displayed current schema location and the contents of the infoset. The location indicator seems to jump ahead a step or two before the infoset is updated.
The step into function seems to sometimes jump ahead as if doing a step over or step out.
The step out seems to be delayed by a step or two, but then doesn't quite exit the current element.
|
@stevedlawrence If you would have time this week could you possibly take a look at this? I would value your feedback greatly on where this is at |
mbeckerle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+0 I guess I'm going to have to read @arosien 's book on Cats Effect and really study it to be able to grok this code. I can't understand this well enough to review it effectively.
08f0cc8 to
ffaea68
Compare
|
@lrbarber Can you give this another look when you have a chance and provide any feedback on what you are seeing? Meaning is step in, step out and step over behaving how you would expect? If not can you describe what you are expecting versus what is actually happening? Thank you |
|
The gif schema looks to be a good example to use while testing step-in/out/over. https://github.com/DFDLSchemas/GIF/blob/master/src/main/resources/com/mitre/gif/xsd/gif.dfdl.xsd |
- Implemented step over and step out logic. - Step in is currently doing the proper thing, fixed in a different PR. Closes #5 Closes apache#1089
ffaea68 to
28a67b6
Compare

Description
Implement step in and step out
Closes #5
Closes #1089
Wiki
Review Instructions including Screenshots
Ensure that stepOver, stepIn and stepOut all work when clicked. Also ensure they do the proper actions