-
Notifications
You must be signed in to change notification settings - Fork 35
Add nuclear processes in AdePT #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SeverinDiederichs
wants to merge
12
commits into
apt-sim:master
Choose a base branch
from
SeverinDiederichs:add_nuclear_processes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add nuclear processes in AdePT #391
SeverinDiederichs
wants to merge
12
commits into
apt-sim:master
from
SeverinDiederichs:add_nuclear_processes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
ca0e84e
to
a305276
Compare
6469703
to
91857b1
Compare
agheata
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this important feature!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the nuclear processes in AdePT.
This PR introduces a
LeakStatus
, which describes for which reason a particle is leaked (e.g., because it hit GammaNuclear or because it left the GPU region). Then, in the Geant4IntegrationLayer, when leaked tracks are handled and given back to Geant4, the nuclear processes are invoked.Therefore, the AdePTGeant4Integration layer now holds a pointer (not-owned) to the specialized
G4HepEmTrackingManager
, that is a member of theAdePTTrackingManager
. TheG4HepEmTrackingManager
holds a pointer to the thread-local hadronic processes. Since there is only a single AdePTTransport instance in async AdePT, each thread must initialize its own Integration layer (this needed to be outsourced), such that it points to the correctG4HepEmTrackingManager
(with the corresponding pointer to the thread-local hadronic process).Physics validation for async AdePT:

Physics validation for sync AdePT:

Performance measurement using 32 threads for 2000 events à 100 e- with 10 GeV being shot at testEm3:
Note: Cannot be merged until we upgrade the CI to the latest version of G4HepEm, CI will fail at the moment.
To Do: