Skip GCC pre-process task if sketch and dependencies do not change.#3112
Open
giulio93 wants to merge 10 commits intoarduino:masterfrom
Open
Skip GCC pre-process task if sketch and dependencies do not change.#3112giulio93 wants to merge 10 commits intoarduino:masterfrom
giulio93 wants to merge 10 commits intoarduino:masterfrom
Conversation
giulio93
changed the title
giulio93
force-pushed
the
master
branch
2 times, most recently
from
9e0a18c to
0a0a741
Compare
per1234
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3112 +/- ##
==========================================
+ Coverage 69.57% 69.62% +0.04%
==========================================
Files 253 253
Lines 19280 19293 +13
==========================================
+ Hits 13414 13432 +18
+ Misses 4628 4625 -3
+ Partials 1238 1236 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
giulio93
force-pushed
the
master
branch
3 times, most recently
from
dca1c06 to
32b1aac
Compare
giulio93
force-pushed
the
master
branch
2 times, most recently
from
5d53241 to
f2230ee
Compare
This changes does some cleanup in the generation and use of the merged sketch (sketch.ino.cpp.merged) and Arduino Preprocessed sketch (sketch.ino.cpp).
6 tasks
giulio93
changed the title
giulio93
changed the title
cmaglie
approved these changes
Mar 3, 2026
dido18
reviewed
Mar 3, 2026
Comment on lines
+315
to
+318
| preprocessedSketch, err := l.makeSourceFile(sketchBuildPath, sketchBuildPath, paths.New(sketch.MainFile.Base()+".cpp")) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
the preprocessedSketch seems not used in the code (the file is removed a few lines below)
Contributor
Author
There was a problem hiding this comment.
The file is removed from the queue, we add it here in order to be able to intercept it
dido18
requested changes
Mar 3, 2026
|
|
||
| b.logIfVerbose(false, i18n.Tr("Generating function prototypes...")) | ||
| if err := b.preprocessSketch(b.libsDetector.IncludeFolders()); err != nil { | ||
| if err := b.preprocessSketch(b.libsDetector.IncludeFolders(), b.libsDetector.IsSketchUnchanged()); err != nil { |
There was a problem hiding this comment.
Why not check the boolean of the sketch here instead of passing the boolean down the preprocessor?
Suggested change
| if err := b.preprocessSketch(b.libsDetector.IncludeFolders(), b.libsDetector.IsSketchUnchanged()); err != nil { | |
| if b.libsDetector.IsSketchUnchanged() { | |
| // log skip unchanged | |
| b.Progress.CompleteStep() | |
| return nli | |
| } | |
| if err := b.preprocessSketch(b.libsDetector.IncludeFolders()); err != nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
In an effort to optimize compilation times, this PR adds the ability to the Arduino CLI to detect whether the Arduino Preprocessing of the sketch could be skipped.
What is the current behavior?
The GCC task is run even if the Task did not changed
What is the new behavior?
The GCC task args are hashed and is stored in order to be able to compare it with prev/next recompile GCC task
Does this PR introduce a breaking change, and is titled accordingly?
Other information