feat: use `theia@1.57.0` by giacomocusinato · Pull Request #2654 · arduino/arduino-ide

giacomocusinato · 2025-03-11T08:17:24Z

Motivation

Use theia@1.57.0.
Note that newer versions are currently not working because of ESM incompatibilty. See theia issue and Prototype ESM-only package workaround for unbundled back end

Change description

Based on #2362
The first commit includes all changes from #2363 rebased into main branch.

Main changes needed for upgrades after theia@1.46.1:

Remove EditorCommandContribution override (1fa0def), since Theia runs save on app startup if "editor.autoSave": "on" is configured in the settings.json eclipse-theia/theia#8722 has been fixed in theia@1.51.0 through this PR
Upgrade yarn.lock dependencies after update to theia@1.53.2; this was needed for some incompatibility with electron builder. After the upgrade, some custom package resolutions is required, (see issue)
Pin electron version to 30.1.2; see https://redirect.github.com/eclipse-theia/theia/pull/14407
Remove TreeViewWidget patches since theia@1.55.1. See fix: align viewsWelcome behavior to VS Code #2543

Other information

Know issues:

ERROR Warning: Unknown event handler property onPointerEnterCapture. Tracked in https://redirect.github.com/eclipse-theia/theia/issues/14633

Reviewer checklist

PR addresses a single concern.
The PR has no duplicates (please search among the Pull Requests before creating one)
PR title and description are properly filled.
Docs have been added / updated (for bug fixes / features)

dankeboy36

Great work

arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts

arduino-ide-extension/src/electron-main/theia/electron-main-application.ts

arduino-ide-extension/src/electron-main/theia/theia-electron-window.ts

dankeboy36 · 2025-03-25T18:00:43Z

electron-app/package.json

-    "vscode-builtin-cpp": "https://open-vsx.org/api/vscode/cpp/1.52.1/file/vscode.cpp-1.52.1.vsix",
-    "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.1.2/vscode-arduino-api-0.1.2.vsix",
+    "vscode-builtin-cpp": "https://open-vsx.org/api/vscode/cpp/1.88.1/file/vscode.cpp-1.88.1.vsix",
+    "vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.2.1/vscode-arduino-api-0.2.1.vsix",


Suggested change

"vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.2.1/vscode-arduino-api-0.2.1.vsix",

"vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.1.2/vscode-arduino-api-0.1.2.vsix",

Thank you! However, it depends on your release plan. I would be happy to see the new API integrated into the IDE nightly, and everything should be compatible, but I can't guarantee anything. If any issues arise, I'm available to help resolve them, or you can revert to a previous version if needed.

Ideally we would merge this PR once ready and release next week after a weekend of nightly test.
I won't mind also postponing the vscode-arduino-api update to the release after this one, to allow for longer nightly testing

I propose reverting the changes for now, and after the IDE release, I will create a follow-up PR. Thank you!

dankeboy36 · 2025-03-26T05:42:06Z

The Theia update is supposed to fix #2148. It would make sense to verify if the CLI daemon can reconnect. The LS reconnection will fail. See here:

arduino-ide/arduino-ide-extension/src/browser/contributions/ino-language.ts

Line 286 in d298b3f

instance: 1, // TODO: get it from the backend

Update: I have not verified it, but I assume IDE has to create a new daemon instance on reconnect, therefore the instance number will change.

Use changes from #2362 and rebase on main branch

Remove `EditorCommandContribution` override, since https://redirect.github.com/eclipse-theia/theia/pull/13683 fixed the unwanted save on startup

Note: align SidebarBottomMenuWidget with Theia new API and HTML structure

See https://redirect.github.com/eclipse-theia/theia/issues/15139

https://redirect.github.com/reactjs/react-tabs/issues/514

Electron version is now pinned, so replace caret only if found

arduino deleted a comment from CLAassistant Mar 11, 2025

giacomocusinato force-pushed the use-theia-latest branch from 4d57906 to 6e9577a Compare March 11, 2025 14:02

arduino deleted a comment from CLAassistant Mar 11, 2025

giacomocusinato force-pushed the use-theia-latest branch from 7868bdb to cb91633 Compare March 19, 2025 12:02

giacomocusinato changed the title ~~[WIP] Use theia@latest~~ Use theia@latest Mar 19, 2025

giacomocusinato added topic: code Related to content of the project itself topic: theia Related to the Theia IDE framework phase: implementation Work is in the implementation phase labels Mar 19, 2025

giacomocusinato changed the title ~~Use theia@latest~~ feat: use theia@latest Mar 19, 2025

giacomocusinato force-pushed the use-theia-latest branch 5 times, most recently from 46637f4 to 8a4b727 Compare March 20, 2025 12:13

giacomocusinato changed the title ~~feat: use theia@latest~~ feat: use theia@1.57.0 Mar 20, 2025

giacomocusinato force-pushed the use-theia-latest branch 5 times, most recently from a69a4e5 to 3adbd1d Compare March 25, 2025 09:08

giacomocusinato marked this pull request as ready for review March 25, 2025 09:10

giacomocusinato added type: enhancement Proposed improvement and removed phase: implementation Work is in the implementation phase labels Mar 25, 2025

giacomocusinato mentioned this pull request Mar 25, 2025

chore: use theia@1.46.1 #2362

Closed

4 tasks

arduino deleted a comment from CLAassistant Mar 25, 2025

dankeboy36 approved these changes Mar 25, 2025

View reviewed changes

giacomocusinato added 3 commits March 28, 2025 20:06

chore: use theia@1.46.1

8053c55

Use changes from #2362 and rebase on main branch

chore: use theia@1.47.0

2b26323

chore: use theia@1.48.3

6d13b00

giacomocusinato added 15 commits March 28, 2025 20:06

chore: use theia@1.50.1

0fdbe70

Remove `EditorCommandContribution` override, since https://redirect.github.com/eclipse-theia/theia/pull/13683 fixed the unwanted save on startup

chore: use theia@1.51.0

3ea0d75

Note: align SidebarBottomMenuWidget with Theia new API and HTML structure

chore: use theia@1.53.2

9510822

chore: update dependencies

cccaa39

fix: prevent use of node-abi@4

6a1a6fd

See https://redirect.github.com/eclipse-theia/theia/issues/15139

fix: upgrade react-tabs to remove library warnings

cacf238

https://redirect.github.com/reactjs/react-tabs/issues/514

chore: use theia@1.54.0

e7bd926

chore: use theia@1.55.1

b0a32df

chore: use theia@1.56.0

85bce1e

chore: use theia@1.57.0

ea47bde

chore: update to typescript v5

479f846

fix: electron version parsing

172544f

Electron version is now pinned, so replace caret only if found

chore: update plugins version

b016b97

fix: prevent puppeteer to download chrome on local build

d4dc5dc

fix: remove CHECK ME comment

f3a2eb9

giacomocusinato force-pushed the use-theia-latest branch from e6cf3cf to f3a2eb9 Compare March 28, 2025 11:11

davegarthsimpson approved these changes Mar 28, 2025

View reviewed changes

giacomocusinato merged commit 859d29d into main Mar 28, 2025
44 checks passed

giacomocusinato deleted the use-theia-latest branch March 28, 2025 16:33

giacomocusinato restored the use-theia-latest branch April 2, 2025 16:24

This was referenced Apr 8, 2025

Auto update fails on Arduino IDE 2.3.5 #2696

Closed

After exiting sleep mode, IDE reloads and changes are lost #2704

Open

This was referenced Apr 11, 2025

"Paste" menu item is not internationalized #2702

Open

Right hand panel UI is broken if Serial Monitor closed while window is loading #2710

Open

per1234 deleted the use-theia-latest branch July 16, 2025 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use `theia@1.57.0`#2654

feat: use `theia@1.57.0`#2654
giacomocusinato merged 18 commits intomainfrom
use-theia-latest

giacomocusinato commented Mar 11, 2025 •

edited

Loading

Uh oh!

dankeboy36 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dankeboy36 Mar 25, 2025

Uh oh!

giacomocusinato Mar 27, 2025 •

edited

Loading

Uh oh!

dankeboy36 Mar 27, 2025

Uh oh!

dankeboy36 commented Mar 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

	"vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.2.1/vscode-arduino-api-0.2.1.vsix",
	"vscode-arduino-api": "https://github.com/dankeboy36/vscode-arduino-api/releases/download/0.1.2/vscode-arduino-api-0.1.2.vsix",

Conversation

giacomocusinato commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Change description

Other information

Reviewer checklist

Uh oh!

dankeboy36 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dankeboy36 Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

giacomocusinato Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dankeboy36 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

dankeboy36 commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

giacomocusinato commented Mar 11, 2025 •

edited

Loading

giacomocusinato Mar 27, 2025 •

edited

Loading

dankeboy36 commented Mar 26, 2025 •

edited

Loading