fix: prevent OutputWidget to gain focus when updated#2681
Merged
davegarthsimpson merged 1 commit intomainfrom Apr 3, 2025
Merged
fix: prevent OutputWidget to gain focus when updated#2681davegarthsimpson merged 1 commit intomainfrom
OutputWidget to gain focus when updated#2681davegarthsimpson merged 1 commit intomainfrom
Conversation
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
giacomocusinato
added
topic: code
davegarthsimpson
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2679
Change description
Prevent
ApplicationShellto set main window focus if revealed widget isOutputWidgetOther information
Although I wasn't able to reproduce the issue in Theia IDE Desktop v1.57.0, seems that the problem might be caused by a regression or an expected change in behaviour in Theia. To deal with the secondary window, Theia might prioritize the main one when
OutputWidgetis refreshed (see eclipse-theia/theia#13493)An issue will follow on Theia side after a deeper analysis or anything new is found.