fix: wait for theia initalWindow to be set before opening sketch through open-file event#2693
Merged
davegarthsimpson merged 2 commits intomainfrom Apr 7, 2025
Merged
Conversation
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
giacomocusinato
added
topic: code
giacomocusinato
force-pushed
the
fix-macos-empty-window
branch
from
23582d8 to
0a6ce3e
Compare
giacomocusinato
temporarily deployed
to
production
GitHub Actions
Inactive
giacomocusinato
changed the title
open-file event after initial window is showninitalWindow to be set before opening sketch through open-file event
davegarthsimpson
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #2688
Change description
Theia internally create an initial empty window on app start to improve UX while first loading the app instance, see eclipse-theia/theia#12897
On MacOS, since open sketch via file association was triggered before initial window reference was set, the open sketch logic would create a new window instance instead of reusing the early created window reference, leaving an unresponsive additional empty window.
Currently there is no ideal way to wait or react to
initialWindowvalue change, so we pool on the value.Note that this only needed on the first window startup as on other instances,
showWindowEarlyis not used andinitialWindowis null.The pool sets a generous amount of retries but should bail consistently on the first try as
initialWindowis set right after the app is ready. Note that in case the pools times out, we open the sketch on a new window anyway.