Remove duplicate native cases in run_binary_exhaustive_both#198
Merged
weikengchen merged 4 commits intoarkworks-rs:masterfrom Feb 28, 2026
Merged
Conversation
Bashmunta
requested review from
mmagician,
weikengchen and
z-tech
and removed request for
a team
weikengchen
approved these changes
Feb 28, 2026
Member
|
(^ triggering the CI with a new line) |
weikengchen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_binary_exhaustive_both was calling the UInt/native test inside the same double combination loop as the UInt/UInt test. Since
test_binary_op_with_native only depends on mode_a, a and b and ignores mode_b, this caused each (mode_a, a, b) triple to be checked three times for the native variant. This change keeps the full exhaustive coverage for the UInt/UInt test, but moves the UInt/native test into a separate loop over b, mirroring run_binary_exhaustive_native_only. As a result, each native case is exercised exactly once per (mode_a, a, b) without losing coverage or wasting constraints.