Skip to content

Conversation

@yelinaung
Copy link

Adding support Java - I'm relatively new to all these so please let me know if I missed anything.
If all goes well, it should fix #88

Your tasks are:
1. Security Review Scope
- Review the security implications of the FILE_CHANGES, focusing on lines marked with “+.” or “-” but take into account how they interact with the whole file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"+." should just be "+"

- Review the security implications of the FILE_CHANGES, focusing on lines marked with “+.” or “-” but take into account how they interact with the whole file.
If it is empty, ignore it.
security_review_checks: |-
2. What to Check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to be a bit more descriptive here if you can. For example instead of just 'Race conditions or concurrency issues' use something like:
"TOCTOU on files: check after normalize and open atomically.
Shared mutable state without proper synchronization"

What you have can still work but results are usually better if you provide more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Java

3 participants