Skip to content

Add a comment to explain why ranged-for cannot be used #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Add a comment to explain why ranged-for cannot be used #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lager/detail/nodes.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ class reader_node : public observable_reader_node<T>
bool garbage = false;

this->observers()(last_);
// We cannot use ranged-for here because children might
// change as a result of notify(). This can invalidate
// the iterators on children, causing undefined behaviors.
// See also https://github.com/arximboldi/lager/pull/212
const auto& children = this->children();
for (size_t i = 0, size = children.size(); i < size; ++i) {
if (auto child = children[i].lock()) {
Expand Down
Loading