fix(console): use useChainPublicClient hook for all chain-specific reads#3948
Open
owenwahlgren wants to merge 1 commit intomasterfrom
Open
fix(console): use useChainPublicClient hook for all chain-specific reads#3948owenwahlgren wants to merge 1 commit intomasterfrom
owenwahlgren wants to merge 1 commit intomasterfrom
Conversation
Replace all 12 usages of walletStore.publicClient with the existing useChainPublicClient() hook across 11 toolbox components. The store's publicClient is hardcoded to Fuji for non-Core wallets, causing waitForTransactionReceipt and readContract to poll the wrong RPC when targeting custom L1s.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publicClientusages fromuseWalletStore()to the existinguseChainPublicClient()hook across 11 toolbox componentspublicClientis hardcoded to Fuji for non-Core wallets, causingwaitForTransactionReceiptandreadContractto poll the wrong RPC when targeting custom L1sAffected components
TeleporterMessenger.tsxTeleporterRegistry.tsxNativeMinter.tsxFeeManager.tsxRewardManager.tsxTransferProxyAdmin.tsxMigrateV1ToV2.tsxDeployICMDemo.tsxMultisigOption.tsxAllowListComponents.tsx(×2)useERC20TokenStakingManager.tsTest plan
Closes #3913
Supersedes #3914