Minor fixes to client and prefetch benchmarks for consistency#1518
Merged
sahityadg merged 4 commits intoawslabs:mainfrom Jul 18, 2025
Merged
Minor fixes to client and prefetch benchmarks for consistency#1518sahityadg merged 4 commits intoawslabs:mainfrom
sahityadg merged 4 commits intoawslabs:mainfrom
Conversation
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
Signed-off-by: Sahitya Damera <[email protected]>
Signed-off-by: Sahitya Damera <[email protected]>
Signed-off-by: Sahitya Damera <[email protected]>
sahityadg
force-pushed
the
benchmark-updates
branch
from
2e79901 to
2184e0c
Compare
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
muddyfish
previously approved these changes
Jul 17, 2025
Contributor
muddyfish
left a comment
muddyfish
left a comment
There was a problem hiding this comment.
Approved - if we could fix the constant issue that would be nice though
| let timeout: Instant = total_start | ||
| .checked_add(max_duration.unwrap_or(Duration::from_secs(86400))) | ||
| .expect("Duration overflow error"); | ||
| let duration = max_duration.unwrap_or(Duration::from_secs(86400)); |
Contributor
There was a problem hiding this comment.
Can 86400 become a constant?
Contributor
Author
There was a problem hiding this comment.
Updated in the latest commit
Signed-off-by: Sahitya Damera <[email protected]>
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
sahityadg
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
mansi153
pushed a commit
to mansi153/mountpoint-s3
that referenced
this pull request
Jul 24, 2025
…s#1518) This change makes prefetch and client benchmarks consistent simplifying the automation ### Does this change impact existing behavior? No, client and prefetch benchmarks only ### Does this change need a changelog entry? Does it require a version change? No, client and prefetch benchmarks only --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Sahitya Damera <[email protected]>
dannycjones
pushed a commit
to c-hagem/mountpoint-s3
that referenced
this pull request
Oct 9, 2025
…s#1518) This change makes prefetch and client benchmarks consistent simplifying the automation ### Does this change impact existing behavior? No, client and prefetch benchmarks only ### Does this change need a changelog entry? Does it require a version change? No, client and prefetch benchmarks only --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). --------- Signed-off-by: Sahitya Damera <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes prefetch and client benchmarks consistent simplifying the automation
Does this change impact existing behavior?
No, client and prefetch benchmarks only
Does this change need a changelog entry? Does it require a version change?
No, client and prefetch benchmarks only
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).