Add max_read_window_size config to prefetcher benchmarks#1566
Open
mansi153 wants to merge 2 commits intoawslabs:mainfrom
Open
Add max_read_window_size config to prefetcher benchmarks#1566mansi153 wants to merge 2 commits intoawslabs:mainfrom
max_read_window_size config to prefetcher benchmarks#1566mansi153 wants to merge 2 commits intoawslabs:mainfrom
Conversation
added 2 commits
August 8, 2025 01:10
Signed-off-by: Mansi Pandey <[email protected]>
Signed-off-by: Mansi Pandey <[email protected]>
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
mansi153
had a problem deploying
to
PR integration tests
GitHub Actions
Failure
sahityadg
reviewed
Aug 8, 2025
| long, | ||
| help = "Initial read window size in bytes, used to dictate how far ahead we request data from S3", | ||
| default_value = "0" | ||
| default_value = "2147483648" |
Contributor
There was a problem hiding this comment.
My understanding is this is a fixed read window size in client benchmarks. So should we rename the parameter to read_window_size?
sahityadg
reviewed
Aug 8, 2025
|
|
||
| client_backpressure: | ||
| read_window_size: !!null #2147483648 | ||
| max_read_window_size: !!null #2147483648 |
Contributor
There was a problem hiding this comment.
Is this a constant read window size or can it go up to this value?
sahityadg
reviewed
Aug 8, 2025
| prefetch_env["EXPERIMENTAL_MOUNTPOINT_NO_DOWNLOAD_INTEGRITY_VALIDATION"] = "ON" | ||
|
|
||
| if self.prefetch_config['max_read_window_size'] is not None: | ||
| prefetch_env["UNSTABLE_MOUNTPOINT_MAX_PREFETCH_WINDOW_SIZE"] = str(self.prefetch_config['max_read_window_size']) |
Contributor
There was a problem hiding this comment.
For prefetcher, we could configure initial and max window size, do we want to configure both? Would it be a like for like comparision with client backpressure benchmark if we just configure max window size?
| long, | ||
| help = "Initial read window size in bytes, used to dictate how far ahead we request data from S3", | ||
| default_value = "0" | ||
| default_value = "2147483648" |
Contributor
There was a problem hiding this comment.
nit: can we also document here somehow that this number corresponds to 2GiB?
| "{iteration}: received {received_size} bytes in {:.2}s: {:.2} Gb/s", | ||
| elapsed.as_secs_f64(), | ||
| (received_size as f64) / elapsed.as_secs_f64() / (1024 * 1024 * 1024 / 8) as f64 | ||
| (received_size as f64) / elapsed.as_secs_f64() / (1000 * 1000 * 1000 / 8) as f64 |
Contributor
There was a problem hiding this comment.
nit: can we make this value more readable? not sure if best to use a clearly named variable or a function to reuse in line 251 too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
max_read_window_sizeconfig to prefetcher benchmarks so we can set the backpressure window max value at runtime.The PR also fixes a few minor things - throughput calculation units from Gib/s to Gb/s, consistency of config names and improving some benchmarking defaults.
Does this change impact existing behavior?
No, benchmarks change only.
Does this change need a changelog entry? Does it require a version change?
No, benchmarks change only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).