Add more parameters to the sweeper combinations for FUSE threads and objects.#1592
Open
tadiwa-aizen wants to merge 1 commit intoawslabs:mainfrom
Open
Add more parameters to the sweeper combinations for FUSE threads and objects.#1592tadiwa-aizen wants to merge 1 commit intoawslabs:mainfrom
tadiwa-aizen wants to merge 1 commit intoawslabs:mainfrom
Conversation
…nd objects. Signed-off-by: Tadiwa Magwenzi <[email protected]>
sahityadg
reviewed
Sep 1, 2025
| params: | ||
| 'benchmarks.fio.direct_io': false, true | ||
| 'benchmarks.fio.fuse_threads': 16 #1, 64 No newline at end of file | ||
| 'benchmarks.fio.fuse_threads': 1, 16, 64 No newline at end of file |
Contributor
There was a problem hiding this comment.
It'd be good to restrict the combinations of app workers and fuse_threads as we don't care about all combinations of these values. Can we specify them as a pair instead?
Contributor
There was a problem hiding this comment.
I had the same suggestion at some point too, but it makes me wonder how feasible it is to maintain and extend a coupled setup like that.
- Does it become more error-prone or something that requires context to update every time?
- Do we really need an increased number of combinations and consequently a stricter sweeper (in mainline), given we only plot 1 object and 16 objects on day-to-day basis; or should this be something one can play around with during investigations on their machine?
- Will our Jupyter notebooks continue to work with some values/combinations of threads/app_workers missing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more parameters to the sweeper combinations for FUSE threads and application workers
What changed and why?
Expanded the parameter combinations in the benchmark sweeper configuration to include more values for testing:
application_workers: Added values 4 and 64 to the existing 1, 16 combinationfuse_threads: Added values 1 and 64 to the existing 16 valueThis change supports an ongoing investigation that requires testing across a broader range of worker and thread configurations.
Does this change impact existing behavior?
No breaking changes. This only adds additional parameter combinations for benchmarking - existing functionality remains unchanged.
Does this change need a changelog entry? Does it require a version change?
No changelog entry or version change required. This is an internal benchmarking configuration change that doesn't affect the public API or user-facing functionality.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).