Fix dependencies for analyzing results from benchmarks#1737
Open
Priyankakarumuru1 wants to merge 2 commits intoawslabs:mainfrom
Open
Fix dependencies for analyzing results from benchmarks#1737Priyankakarumuru1 wants to merge 2 commits intoawslabs:mainfrom
Priyankakarumuru1 wants to merge 2 commits intoawslabs:mainfrom
Conversation
Signed-off-by: Priyankakarumuru1 <[email protected]>
Priyankakarumuru1
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Priyankakarumuru1
changed the title
sahityadg
reviewed
Jan 7, 2026
benchmark/pyproject.toml
Outdated
| dev = [ | ||
| "pytest", | ||
| ] | ||
| analysis = [ |
Contributor
There was a problem hiding this comment.
Have you tried adding these to dev dependency-group like pytest?
That may be better as it won't need --group flag.
Contributor
Author
There was a problem hiding this comment.
That is actually much clear. I'll move omegaconf and tabulate to the dev group instead of creating a separate analysis group. Thanks for the suggestion!
Contributor
There was a problem hiding this comment.
These dependencies are already defined here: https://github.com/awslabs/mountpoint-s3/blob/main/benchmark/analysis-scripts/autogroup.py#L3-L6. So uv should just install them anyway. We don't need them in pyproject.toml unless we want to move all dependencies here.
Signed-off-by: Priyankakarumuru1 <[email protected]>
Priyankakarumuru1
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why?
Added analysis dependency group to pyproject.toml containing omegaconf and tabulate packages required by the autogroup.py script for processing benchmark results.
Does this change impact existing behavior?
No
Does this change need a changelog entry? Does it require a version change?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).