Fix divide by zero exception in InterlockingGenerator.#9925
Fix divide by zero exception in InterlockingGenerator.#9925mpaperno wants to merge 1 commit intobambulab:masterfrom
InterlockingGenerator.#9925Conversation
… configuration parameters are used. (fixes bambulab#9910 )
|
Somewhat related: The generator hangs during slicing when the beam width gets "too small". I'm not clear on what defines the actual practical lower limit. For example on an arbitrary test object (some text on bottom of a cube), using @Noisyfox Perhaps you can take a look? (I think you originally ported this? If not, sorry and NVM!) It's probably preferable not to impose some arbitrary minimum, if it could be calculated. Or maybe the algorithm could be improved to skip unworkable cells? There's no way to exit gracefully after a hang, the "stop" button in the status bar window is ineffective. Which is likely a separate issue in general (haven't looked). -Max |
Fixes #9910
There's a more fundamental issue in that the current config option minimum/maximum value types are
int, so setting a minimum of something like0.1doesn't work (minimum becomes zero). The GUI validation then doesn't work as expected. Some of the code seems to completely ignore that fact, like for this interlocking beam width option:BambuStudio/src/libslic3r/PrintConfig.cpp
Line 3379 in 6a3e8bb
I'll likely submit a PR for that fix next, unless it turns into a bigger deal than it appears so far.
Thanks,
-Max