Avoid using strncpy_s in two cases, and fix third

Fixes #15 - corecrt_internal_string_templates.h line 218 buffer is too
small.

Author: benbuck

src/Path.cpp

@@ -234,9 +234,7 @@ bool getExecutablePathComponents()
         WARNING_PRINTF("unexpected length mismatch, GetModuleFileNameA %zu, strlen %zu\n", length, strlen(moduleFullPath));
     }
 
-    executableFullPath_.reserve(length + 1);
-    executableFullPath_.resize(length);
-    strncpy_s(&executableFullPath_[0], length + 1, moduleFullPath, length);
+    executableFullPath_ = moduleFullPath;
     DEBUG_PRINTF("executable full path: %s\n", executableFullPath_.c_str());
 
     CHAR * fileName = PathFindFileNameA(moduleFullPath);
@@ -259,10 +257,7 @@ bool getExecutablePathComponents()
         return false;
     }
 
-    length = strlen(moduleFullPath);
-    executableDir_.reserve(length + 1);
-    executableDir_.resize(length);
-    strncpy_s(&executableDir_[0], length + 1, moduleFullPath, length);
+    executableDir_ = moduleFullPath;
     DEBUG_PRINTF("executable dir: %s\n", executableDir_.c_str());
 
     return true;

src/TrayIcon.cpp

@@ -98,7 +98,8 @@ void TrayIcon::updateTip(const std::string & tip)
 {
     if (nid_.uID) {
         DEBUG_PRINTF("updating tray icon %u tip to %s\n", nid_.uID, tip.c_str());
-        strncpy_s(nid_.szTip, tip.c_str(), sizeof(nid_.szTip) / sizeof(nid_.szTip[0]));
+        size_t tipMaxSize = sizeof(nid_.szTip) / sizeof(nid_.szTip[0]);
+        strncpy_s(nid_.szTip, tip.c_str(), tipMaxSize - 1);
         if (!Shell_NotifyIconA(NIM_MODIFY, &nid_)) {
             WARNING_PRINTF(
                 "could not update tray icon tip, Shell_NotifyIcon() failed: %s\n",