Skip to content

[FIX] Widget shortcuts now work even if menu bar is not visible #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Widget shortcuts do not work if menu bar is not visible.

Fixes: biolab/orange3#7021

Description of changes
  • Add all actions to top level widget
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.04%. Comparing base (6de8d8f) to head (e882983).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   72.04%   72.04%           
=======================================
  Files          34       34           
  Lines        9114     9116    +2     
=======================================
+ Hits         6566     6568    +2     
  Misses       2548     2548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Shortcuts would not work if menu bar is not visible.
@markotoplak
Copy link
Member

markotoplak commented Feb 14, 2025

This fixes keyboard shortcuts on Linux. I tested Control+C in Scatter Plot. Did not work on master, works on this branch.

@markotoplak markotoplak removed their assignment Feb 14, 2025
@thocevar
Copy link
Contributor

Solves the problem on Windows as well.

@thocevar thocevar removed their assignment Feb 14, 2025
@markotoplak markotoplak changed the title [FIX] widget: Add all actions to top level widget [FIX] Widget shortcuts now work even if menu bar is not visible Feb 14, 2025
@markotoplak markotoplak merged commit 950fc29 into biolab:master Feb 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy Image to Clipboard with hidden Menu Bar
5 participants