- make cachestat compatible with older bash versions#37
Open
Sinnohd wants to merge 2 commits intobrendangregg:masterfrom
Open
- make cachestat compatible with older bash versions#37Sinnohd wants to merge 2 commits intobrendangregg:masterfrom
Sinnohd wants to merge 2 commits intobrendangregg:masterfrom
Conversation
Owner
|
Thank you, but no. I object to performance tools that themselves waste performance without a really good reason. This change would do an extra fork/exec for every interval. I understand the reason, but I don't think it's a really good one. I'd also not be that interested in code that checked the bash version and then made an appropriate choice -- obfuscating the script, without a really good reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of bash are not supporting the printf %(FORMAT)T format. I quickly added a date based subtraction.
If someone has time, he can also implement a version check and use the printf with newer bash versions (less overhead) and the date part with older.