Grep for warnings in run_and_print_on_failure function #1869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
Signed-off-by: Lars Erik Wik <[email protected]>
craigcomstock
requested changes
Sep 3, 2025
| @@ -623,10 +623,15 @@ run_and_print_on_failure() | |||
|
|
|||
| local exit_code=0 | |||
| if "$@" > "$temp_output_file" 2>&1; then | |||
| : # NOOP | |||
| if grep -q "warning:" "$temp_output_file"; then | |||
There was a problem hiding this comment.
seems like we would absolutely want also error and/or fail in the grep as well as maybe a few lines of context with -C 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.