Open
Conversation
Problem: some hidden subcommands of diodcli(1) are unit tests but linkage to the original problem is missing. Add some issue references to the code.
grondo
approved these changes
Dec 17, 2025
Problem: it's not obvious who maintains diod. List the people with maintainer access or greater in a MAINTAINERS.md file.
Member
Author
|
Just pushed a format change to the MAINTAINERS.ms, pilfered from https://github.com/opensearch-project/index-management/blob/main/MAINTAINERS.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
MAINTAINERS.mdfile containing @garlick, @grondo, and @chu11 (and I made us all admins of this project).Also, I tacked on an unrelated commit that just adds some comments to test code referencing the original github issues.
I'lll ask for approval from @grondo and @chu11 before merging.