This repository was archived by the owner on May 23, 2024. It is now read-only.
Cleanup travis configuration for old artifcats#2
Open
matthiasbeyer wants to merge 1 commit intoclap-rs:masterfrom
Open
Cleanup travis configuration for old artifcats#2matthiasbeyer wants to merge 1 commit intoclap-rs:masterfrom
matthiasbeyer wants to merge 1 commit intoclap-rs:masterfrom
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
epage
suggested changes
Dec 8, 2019
Member
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
I'd recommend checking out my travis config over at
https://github.com/epage/status/blob/master/.travis.yml
| script: | ||
| - rustup component add clippy-preview | ||
| - cargo clippy -- -D warnings | ||
| - rust: 1.27.2 |
Member
There was a problem hiding this comment.
The advantage of pinning the version for rustfmt is your CI won't break when a new version of Rust is out that tweaks the format.
| script: | ||
| - cargo fmt --all -- --write-mode=diff | ||
| - cargo build --all --all-features | ||
| - cargo test --all --all-features |
Author
There was a problem hiding this comment.
Yeah, but only temporarily until I figured out what to do with the codebase (maybe a big"ish" refactoring).
|
|
||
| script: | ||
| - cargo fmt --all -- --write-mode=diff | ||
| - cargo build --all --all-features |
Member
There was a problem hiding this comment.
If you want, you could just run cargo check
| - cargo fmt --all -- --write-mode=diff | ||
|
|
||
| script: | ||
| - cargo fmt --all -- --write-mode=diff |
Member
There was a problem hiding this comment.
Besides not pinning rustfmt, a disadvantage of running it in the regular job is that it will be duplicated per environment which I doubt you need.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.