-
-
Notifications
You must be signed in to change notification settings - Fork 156
feat: Add variable resource_requirements #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add variable resource_requirements #298
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis pull request integrates a new input variable, Changes
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Gentle ping to consider this PR. It would avoid requiring a fork on our end just to manage GPU-based workloads. |
The `resource_requirements` variable is supported by the `aws_ecs_task_definition` resource. This allows users to specify the type and amount of resources (like GPUs) to assign to a container.
6dba3fe
to
627f736
Compare
what
The
resource_requirements
variable is supported by theaws_ecs_task_definition
resource. This allows users to specify the type and amount of resources (like GPUs) to assign to a container.why
Allow forwarding this variable to the
ecs-container-definition/aws
module, which already supports it.