L1Trk reco enabling CheckHistory by default by tschuh · Pull Request #43690 · cms-sw/cmssw

tschuh · 2024-01-10T12:06:58Z

This PR enables the CheckHistory option by default. Without this check there's a danger of people running CMSSW 14 L1Trk reco on stubs from earlier MC getting nonsense results and not realizing it. This PR got requested by @tomalin

cmsbuild · 2024-01-10T12:07:23Z

cms-bot internal usage

cmsbuild · 2024-01-10T12:12:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43690/38371

This PR adds an extra 16KB to repository

cmsbuild · 2024-01-10T12:12:30Z

A new Pull Request was created by @tschuh for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet (l1)
L1Trigger/TrackerDTC (upgrade, l1)
L1Trigger/TrackerTFP (l1)

@epalencia, @aloeliger, @subirsarkar, @srimanob, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @erikbutz, @Martin-Grunewald, @skinnari this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2024-01-16T09:23:16Z

@BenjaminRS I was pretty jet lagged yesterday and hadn't slept in 48 hours, so I'm not too sure, but I seem to recall this coming up yesterday, were you aware of this PR?

aloeliger · 2024-01-16T09:23:46Z

please test

cmsbuild · 2024-01-16T11:17:37Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-254412/36831/summary.html
COMMIT: d16d0f2
CMSSW: CMSSW_14_0_X_2024-01-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.8311

----- Begin Fatal Exception 16-Jan-2024 10:50:07 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 16-Jan-2024 10:50:07 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD
----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 16-Jan-2024 10:50:08 CET-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=ElectronMVAValueMapProducer label='electronMVAValueMapProducer'
Exception Message:
edm::FileInPath unable to find file RecoEgamma/ElectronIdentification/data/MVAWeightFiles/Winter22HZZV1/EB1_5.weights.xml.gz anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43690/36831/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02820/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_0_X_2024-01-15-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

BenjaminRS · 2024-01-16T14:14:27Z

@BenjaminRS I was pretty jet lagged yesterday and hadn't slept in 48 hours, so I'm not too sure, but I seem to recall this coming up yesterday, were you aware of this PR?

Thanks @aloeliger for the notification. I was not aware of the PR. Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

aloeliger · 2024-01-17T10:15:05Z

please test

mmusich · 2024-01-17T10:17:37Z

please test

What's the purpose of this re-test?

Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

This PR will never pass integration tests (see e.g. this log).

aloeliger · 2024-01-17T10:19:49Z

please test

What's the purpose of this re-test?

Looks like with this in place it will now throw an exception if the tracking is run on earlier MC.

This PR will never pass integration tests (see e.g. this log).

@mmusich Apologies, I was looking at the failed test earlier that seemed to have been a temporary issue and just retriggering as I had done for another L1 PR.

aloeliger · 2024-01-17T10:20:46Z

please abort

cmsbuild · 2024-07-08T11:08:39Z

Pull request #43690 was updated. @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild · 2024-08-27T08:09:14Z

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

antoniovilela · 2024-09-03T09:41:10Z

ping (to make bot change milestone)

tomalin · 2024-10-13T10:49:47Z

Hi, this PR has been on hold for a long time. If people don't want this kind of check in CMSSW by default, could we at least please merge this PR with the "CheckHistory" default setting to "False", so we make available the bug fix to this check, for those people that wish to enable this option?

cmsbuild · 2024-11-22T13:11:22Z

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.

cmsbuild · 2025-02-07T08:32:10Z

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

CheckHistory enabled by default.

d16d0f2

cmsbuild added this to the CMSSW_14_0_X milestone Jan 10, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending trk labels Jan 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 16, 2024

cmsbuild added tests-rejected and removed tests-started labels Jan 16, 2024

cmsbuild added tests-started and removed tests-rejected labels Jan 17, 2024

cmsbuild added tests-pending and removed tests-started labels Jan 17, 2024

cmsbuild mentioned this pull request Aug 8, 2024

Displaced vertexing gbdt #45672

Merged

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024

cmsbuild mentioned this pull request Sep 11, 2024

Several improvements to L1 tracking code #45974

Closed

cmsbuild mentioned this pull request Oct 12, 2024

Several improvements to L1 tracking code #46360

Merged

cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_15_0_X Nov 22, 2024

This was referenced Jan 8, 2025

L1 tracking update #47056

Closed

L1 tracking update #47067

Merged

cmsbuild modified the milestones: CMSSW_15_0_X, CMSSW_15_1_X Feb 7, 2025

tschuh closed this by deleting the head repository May 13, 2025

Conversation

tschuh commented Jan 10, 2024

Uh oh!

cmsbuild commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 10, 2024

Uh oh!

cmsbuild commented Jan 10, 2024

Uh oh!

aloeliger commented Jan 16, 2024

Uh oh!

aloeliger commented Jan 16, 2024

Uh oh!

cmsbuild commented Jan 16, 2024

RelVals

RelVals-INPUT

Uh oh!

BenjaminRS commented Jan 16, 2024

Uh oh!

aloeliger commented Jan 17, 2024

Uh oh!

mmusich commented Jan 17, 2024

Uh oh!

aloeliger commented Jan 17, 2024

Uh oh!

aloeliger commented Jan 17, 2024

Uh oh!

cmsbuild commented Jul 8, 2024

Uh oh!

cmsbuild commented Aug 27, 2024

Uh oh!

antoniovilela commented Sep 3, 2024

Uh oh!

tomalin commented Oct 13, 2024

Uh oh!

cmsbuild commented Nov 22, 2024

Uh oh!

cmsbuild commented Feb 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cmsbuild commented Jan 10, 2024 •

edited

Loading