BPHNanoAODs by gmelachr · Pull Request #47469 · cms-sw/cmssw

gmelachr · 2025-02-27T03:17:27Z

Following the presentation in the xPOG meeting (https://indico.cern.ch/event/1509026/#2-bph-custom-nanoaod), this is the PR for the BPH-flavor nanoAODs.

FYI: @drkovalskyi @gkaratha @hqucms @ftorrresd

Add PhysicsTools/BPHNano files

cmsbuild · 2025-02-27T03:17:53Z

cms-bot internal usage

cmsbuild · 2025-02-27T03:19:04Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/43900/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

vlimant · 2025-03-03T09:47:04Z

assign xpog

vlimant · 2025-03-03T09:50:06Z

please include how this would be ran within a cmsDriver command ; and this will likely require the --step NANO:@BPH to be implemented.

ftorrresd · 2025-03-03T10:57:04Z

enable nano

ftorrresd · 2025-03-03T10:57:30Z

please test

ftorrresd · 2025-03-03T11:07:08Z

Hi @gmelachr -- as a follow-up on Jean-Roch's comment, usually NanoAOD flavors implement their customizations and make them related to a new sequence at autoNANO.py

https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/autoNANO.py

makortel · 2025-03-07T21:48:02Z

The binary files should be placed in a (new?) repository in https://github.com/cms-data/

makortel · 2025-03-07T21:49:23Z

PhysicsTools/BPHNano/src/classes_def.xml

This is a wrong package to define dictionaries for persistable data products (see https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts#Restrictions_on_the_package_defi).

makortel · 2025-03-07T21:52:42Z

PhysicsTools/BPHNano/src/classes_def.xml

+ <class name="reco::TransientTrack"/> 
+ <class name="std::vector<reco::TransientTrack>"  ClassVersion="6">
+    <version ClassVersion="6" checksum="1695337441"/>
+ </class>
+ <class name="edm::Wrapper<std::vector<reco::TransientTrack> >"/>


Dictionaries for reco::TransientTrack must be defined in the package that defines the class, i.e. TrackingTools/TransientTrack. Given that that package is a non-DataFormat package, the dictionary for Wrapper must be declared as transient along

<class name="edm::Wrapper<std::vector<reco::TransientTrack> >" persistent="false"/>

The dictionary for std::vector<reco::TransientTrack> should not specify class version (because it is an instantiation of a class template).

makortel · 2025-03-07T21:56:29Z

PhysicsTools/BPHNano/src/classes_def.xml

+ <class name="KinVtxFitter"/>
+ <class name="std::vector<KinVtxFitter>"/>
+ <class name="edm::Wrapper<std::vector<KinVtxFitter> >"/>


If dictionary for KinVtxFitter is needed, the Wrapper must be declared as transient

<class name="edm::Wrapper<std::vector<KinVtxFitter> >" persistent="false"/>

However, it seems not to be put into the edm::Event in the present form of this PR (I only saw commented-out code). If it is not necessary to put it into edm::Event, I'd suggest to remove that commented-out code and these dictionary declarations.

makortel · 2025-03-07T21:58:10Z

PhysicsTools/BPHNano/src/classes_def.xml

+ <class name="edm::RefProd<pat::CompositeCandidateCollection>" />
+ <class name="edm::Association<pat::CompositeCandidateCollection>" />
+ <class name="edm::Wrapper<edm::Association<pat::CompositeCandidateCollection> >" />


These dictionaries must go to the package that defines pat::CompositeCandidateCollection, i.e. DataFormats/PatCandidates.

makortel · 2025-03-07T21:58:41Z

PhysicsTools/BPHNano/src/classes.h

+namespace {
+  struct dictionary {
+      std::vector<reco::TransientTrack> ttv;
+      edm::Wrapper<std::vector<reco::TransientTrack> > wttv; 
+      edm::Wrapper<std::vector<KinVtxFitter> > wkv;
+  };
+}


This dummy struct is not needed (since long time).

Suggested change

namespace {

struct dictionary {

std::vector<reco::TransientTrack> ttv;

edm::Wrapper<std::vector<reco::TransientTrack> > wttv;

edm::Wrapper<std::vector<KinVtxFitter> > wkv;

};

}

Cmssw 15 1 x

cmsbuild · 2025-03-10T10:09:55Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Custom Phase-2 L1 Trigger NanoAOD #47178, Add era modifiers for ScoutingNano to account for changes in 2022-24 and beginning of 2025 #47302

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44011/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

gmelachr · 2025-03-10T10:14:46Z

Hi @gmelachr -- as a follow-up on Jean-Roch's comment, usually NanoAOD flavors implement their customizations and make them related to a new sequence at autoNANO.py

https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/autoNANO.py

Hello, the BPH-flavor has been added in the autoNANO.py

@ftorrresd @vlimant The cmsDriver command is:

cmsDriver.py --conditions 140X_dataRun3_Prompt_v4 --datatier NANOAOD --era Run3,run3_nanoAOD_pre142X --eventcontent NANOAOD --filein root://cms-xrd-global.cern.ch//store/data/Run2024C/ParkingDoubleMuonLowMass0/MINIAOD/PromptReco-v1/000/379/415/00000/b40397b5-61c6-4887-8f4e-025e8ca925ee.root --fileout file:/tmp/gmelachr/BPH_test_data.root --nThreads 4 -n -1 --no_exec --python_filename BPH_test.py --scenario pp --step NANO:@bph

@makortel 's comments are work in progress

cmsbuild · 2025-03-11T13:21:38Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): Custom Phase-2 L1 Trigger NanoAOD #47178, Add era modifiers for ScoutingNano to account for changes in 2022-24 and beginning of 2025 #47302

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47469/44039/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

gmelachr · 2025-03-15T17:09:12Z

The review of the PR continues at #47603

gmelachr and others added 2 commits February 27, 2025 04:06

Add PhysicsTools/BPHNano files

72f078c

import BPH framework to CMSSW_15_1

46b3bfd

Add PhysicsTools/BPHNano files

cmsbuild added this to the CMSSW_15_1_X milestone Feb 27, 2025

cmsbuild added pending-signatures tests-pending orp-pending new-package-pending code-checks-pending changes-dataformats labels Feb 27, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 27, 2025

cmsbuild added the xpog-pending label Mar 3, 2025

cmsbuild added tests-started and removed tests-pending labels Mar 3, 2025

makortel reviewed Mar 7, 2025

View reviewed changes

gmelachr and others added 3 commits March 10, 2025 10:30

BPHNano: general update to make cmsDriver command work

a8c6d98

Merge branch 'master' into CMSSW_15_1_X

1f92008

BPHNano: General update to make cmsDriver command work

efb8c05

Cmssw 15 1 x

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-rejected labels Mar 10, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 10, 2025

Merge branch 'cms-sw:master' into master

ec58822

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 11, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 11, 2025

gmelachr closed this by deleting the head repository Mar 11, 2025

This was referenced Mar 15, 2025

From cmssw 15 1 0 pre1 gmelachr/cmssw#2

Closed

BPHNanoAODs #47603

Merged

Conversation

gmelachr commented Feb 27, 2025

Uh oh!

cmsbuild commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Feb 27, 2025

Uh oh!

vlimant commented Mar 3, 2025

Uh oh!

vlimant commented Mar 3, 2025

Uh oh!

ftorrresd commented Mar 3, 2025

Uh oh!

ftorrresd commented Mar 3, 2025

Uh oh!

ftorrresd commented Mar 3, 2025

Uh oh!

makortel commented Mar 7, 2025

Uh oh!

makortel Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

makortel Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Mar 10, 2025

Uh oh!

gmelachr commented Mar 10, 2025

Uh oh!

cmsbuild commented Mar 11, 2025

Uh oh!

gmelachr commented Mar 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Feb 27, 2025 •

edited

Loading