-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add MIPs sum and noise quadratic sum to HGCAL calibration cell handler #49598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49598/47140 |
|
A new Pull Request was created by @RSalvatico for master. It involves the following packages:
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
assign hgcal-dpg |
|
New categories assigned: hgcal-dpg @cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
test parameters:
|
|
please test |
|
+1 |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The kernel
handleCalibCellperforms the energy sum and the weighted timing average of rechits in calibration and surrounding cells in HGCAL Si sensors. This PR adds:PR validation:
Validated with some private tests using the hgcal-comm package,
as this piece of code isn't currently exercised by any CMSSW workflow(this is not true anymore). In any case, this PR builds on top of PR #47829 and only adds similar, straightforward sum operations.@pfs @fabio-mon