Skip to content

Conversation

@RSalvatico
Copy link
Contributor

@RSalvatico RSalvatico commented Dec 11, 2025

PR description:

The kernel handleCalibCell performs the energy sum and the weighted timing average of rechits in calibration and surrounding cells in HGCAL Si sensors. This PR adds:

  • the sum operation for the energy expressed in number of MIPs;
  • the sum in quadrature of the noise between calibration and surrounding cells.

PR validation:

Validated with some private tests using the hgcal-comm package, as this piece of code isn't currently exercised by any CMSSW workflow (this is not true anymore). In any case, this PR builds on top of PR #47829 and only adds similar, straightforward sum operations.

@pfs @fabio-mon

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

  • RecoLocalCalo/HGCalRecAlgos (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@IzaakWN, @ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@RSalvatico
Copy link
Contributor Author

assign hgcal-dpg

@cmsbuild
Copy link
Contributor

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

@pfs
Copy link
Contributor

pfs commented Dec 11, 2025

test parameters:

  • enable = gpu
  • workflow = 77.0
  • workflow_gpu = 77.0
  • workflow_options_gpu = -w standard,gpu

@pfs
Copy link
Contributor

pfs commented Dec 11, 2025

please test

@pfs
Copy link
Contributor

pfs commented Dec 11, 2025

+1

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7918b5/49900/summary.html
COMMIT: 4c52086
CMSSW: CMSSW_16_0_X_2025-12-10-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49598/49900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 20 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 142
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273079
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 228 log files, 199 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 242 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148855
  • DQMHistoTests: Total failures: 29816
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 119030
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 43 log files, 46 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 214 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148855
  • DQMHistoTests: Total failures: 37345
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 111498
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 43 log files, 46 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 253 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148855
  • DQMHistoTests: Total failures: 28782
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 120064
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 43 log files, 46 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 222 differences found in the comparisons
  • Reco comparison had 6 failed jobs
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 148855
  • DQMHistoTests: Total failures: 35679
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 113168
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 43 log files, 46 edm output root files, 11 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 712e925 into cms-sw:master Dec 15, 2025
23 checks passed
@RSalvatico RSalvatico deleted the calibCellKernel branch December 15, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants