Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 11, 2025

PR description:

This branch introduces a set of improvements and validation features for vertex matching and validation within the cmssw framework.
This code was developed in the context of the 19th Patatrack Hackathon that took place in the week of 5 Sept 2025 → 19 Sept 2025.
This update was co-authored by NGT Task 3.1.1 @rovere @Parsifal-2045 @JanGerritSchulz @elenavernazza @bfonta

Enhanced Matching Logic
  • Extends vertex matching parameters by adding new criteria such as fraction of $\sum p_T^2$ and fraction of $1/\sigma_{d_z}$ alongside the existing shared tracks metrics.
Configuration Improvements
  • Makes maxEta configurable for Phase-2, enhancing flexibility for future validation scenarios.
  • Introduces a "reconstructable" sim-vertex flag, allowing the validation module to optionally focus only on sim vertices that meet reconstruction criteria (≥3 associated tracks).
  • Adds configurability for the reconstructable-vertex criteria.
New Validation Output
  • Adds new validation histograms to support monitoring and assessment of vertex matching performance.
  • Includes additional chi² and normalized chi² histograms for reconstructed vertices.

PR validation:

The code was extensively validated during the 19th Patatrack Hackathon in a variety of configurations.
The outcome was presented at:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

type ngt

@cmsbuild cmsbuild added the ngt label Dec 11, 2025
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTriggerOffline/Common (dqm)
  • SimTracker/VertexAssociation (simulation)
  • Validation/RecoVertex (dqm)

@civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @kpedro88, @mdhildreth, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @felicepantaleo, @missirol, @mmasciov, @mmusich, @mtosi, @rovere, @threus, @venturia this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

test parameters:

  • workflow = ph2_hlt

@mmusich
Copy link
Contributor Author

mmusich commented Dec 11, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 220KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f442/49906/summary.html
COMMIT: be399f1
CMSSW: CMSSW_16_0_X_2025-12-11-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49609/49906/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4505264
  • DQMHistoTests: Total failures: 11635
  • DQMHistoTests: Total nulls: 154
  • DQMHistoTests: Total successes: 4493455
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 42680.16199999998 KiB( 54 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 3336.274 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 34434.0,... ): 9.842 KiB Vertexing/PrimaryVertexV
  • Checked 235 log files, 208 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 10 / 53 workflows

@civanch
Copy link
Contributor

civanch commented Dec 12, 2025

+1

regression differences are likely due to change of algorithms.

elenavernazza and others added 2 commits December 12, 2025 14:11
Introduce match by fraction of sumPt2 and fraction of 1/dZError
alongside plain number of shared tracks and fraction of shared tracks
- neutralize significance cut in VertexAssociatorByPositionAndTracks by default
- rename sim_vertices_num_shared_tracks to sim_vertices_shared_fraction
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #49609 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 12, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 224KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-36f442/49927/summary.html
COMMIT: 7af5710
CMSSW: CMSSW_16_0_X_2025-12-12-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49609/49927/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 54 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 73
  • DQMHistoTests: Total histograms compared: 5015557
  • DQMHistoTests: Total failures: 13569
  • DQMHistoTests: Total nulls: 188
  • DQMHistoTests: Total successes: 5001780
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 102733.09399999997 KiB( 72 files compared)
  • DQMHistoSizes: changed ( 34434.7501,... ): 3336.274 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 12434.7,... ): 6.566 KiB Vertexing/PrimaryVertexV
  • DQMHistoSizes: changed ( 16834.0,... ): 5613.913 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 16834.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 9.842 KiB Vertexing/PrimaryVertexV
  • Checked 295 log files, 253 edm output root files, 73 DQM output files
  • TriggerResults: found differences in 27 / 71 workflows

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5867bc4 into cms-sw:master Dec 15, 2025
11 checks passed
@mmusich mmusich deleted the ngt_vertexing_validation branch December 15, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants