-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[NGT] Vertexing Validation Improvements: enhanced matching criteria, configurability, and new histograms #49609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NGT] Vertexing Validation Improvements: enhanced matching criteria, configurability, and new histograms #49609
Conversation
|
cms-bot internal usage |
|
type ngt |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49609/47144 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @kpedro88, @mdhildreth, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 220KB to repository Comparison SummarySummary:
|
|
+1 regression differences are likely due to change of algorithms. |
Validation/RecoVertex/interface/PrimaryVertexAnalyzer4PUSlimmed.h
Outdated
Show resolved
Hide resolved
Introduce match by fraction of sumPt2 and fraction of 1/dZError alongside plain number of shared tracks and fraction of shared tracks
- neutralize significance cut in VertexAssociatorByPositionAndTracks by default - rename sim_vertices_num_shared_tracks to sim_vertices_shared_fraction
be399f1 to
7af5710
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49609/47152 |
|
Pull request #49609 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again. |
|
please test |
|
+1 Size: This PR adds an extra 224KB to repository Comparison SummarySummary:
|
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This branch introduces a set of improvements and validation features for vertex matching and validation within the
cmsswframework.This code was developed in the context of the 19th Patatrack Hackathon that took place in the week of 5 Sept 2025 → 19 Sept 2025.
This update was co-authored by NGT Task 3.1.1 @rovere @Parsifal-2045 @JanGerritSchulz @elenavernazza @bfonta
Enhanced Matching Logic
Configuration Improvements
maxEtaconfigurable for Phase-2, enhancing flexibility for future validation scenarios.New Validation Output
PR validation:
The code was extensively validated during the 19th Patatrack Hackathon in a variety of configurations.
The outcome was presented at:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, no backport needed.